Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 9447055: Roll Skia DEPS 3230->3244 (Closed)

Created:
8 years, 10 months ago by epoger
Modified:
8 years, 10 months ago
Reviewers:
reed1
CC:
chromium-reviews, enne (OOO)
Visibility:
Public.

Description

Roll Skia DEPS 3230->3244 This will cause the following layout test to fail on all platforms: GPU : fast/canvas/canvas-strokePath-shadow.html After this change lands, I will update that test to be less fragile by allowing for tolerance (at least +-1, but a 2 is probably better) since the failing values had to be premultiplied and then unpremultiplied, which varies a tiny bit between implementations (even between diff GPUs). See trybot results in https://chromiumcodereview.appspot.com/9452031/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
[created my own CL from Mike's roll in https://chromiumcodereview.appspot.com/9452031/ , so that I can land ...
8 years, 10 months ago (2012-02-24 14:48:55 UTC) #1
epoger
[adding enne, who is current webkit gardener according to the schedule]
8 years, 10 months ago (2012-02-24 14:57:43 UTC) #2
reed1
lgtm
8 years, 10 months ago (2012-02-24 15:08:44 UTC) #3
epoger
The layout test fix will go here: https://bugs.webkit.org/show_bug.cgi?id=79488 ('Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance')
8 years, 10 months ago (2012-02-24 15:34:34 UTC) #4
epoger
8 years, 10 months ago (2012-02-24 20:12:16 UTC) #5
On 2012/02/24 15:34:34, epoger wrote:
> The layout test fix will go here: 
> https://bugs.webkit.org/show_bug.cgi?id=79488 ('Make
> fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance')

The layout test fix has landed in WebKit as
http://trac.webkit.org/changeset/108835 .

Once that gets rolled into Chrome, the fast/canvas/canvas-strokePath-shadow.html
tests should stop failing in the chrome.webkit waterfall.

Powered by Google App Engine
This is Rietveld 408576698