Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 9443044: Beginnings of some msvs_... emulation (windows ninja) (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 9 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Starting with additional includes, defines, and some basic cflags and ldflags. Committed: https://code.google.com/p/gyp/source/detail?r=1243

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : refactor a bit #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : moar flags handled #

Patch Set 7 : more flags, base_unitests links now #

Patch Set 8 : use MSVSVersion module to set relevant variables #

Patch Set 9 : add warnings as errors test #

Patch Set 10 : optimization settings test #

Patch Set 11 : add debug format and rtti tests #

Patch Set 12 : add tests for buff sec, func level link, runtime checks, runtime lib #

Patch Set 13 : add tests for exceptions and additional #

Patch Set 14 : add test for linker debuginfo #

Patch Set 15 : test for target machine, character set #

Patch Set 16 : test for delayload, subsystem #

Patch Set 17 : test for incremental, library dirs #

Patch Set 18 : test for additional deps, additional opts, default libs #

Patch Set 19 : test for aslr, fixed base #

Patch Set 20 : test for DEP #

Patch Set 21 : test for ltcg, comdat, optref #

Patch Set 22 : name for pdb #

Patch Set 23 : refactor flag extraction to be shorter #

Patch Set 24 : fix pdb name #

Patch Set 25 : no pdb option for LIB #

Total comments: 44

Patch Set 26 : rebase? #

Patch Set 27 : another rebase attempt #

Patch Set 28 : and again #

Patch Set 29 : review fixes #

Patch Set 30 : comment fixes #

Total comments: 17

Patch Set 31 : some style fixes' #

Patch Set 32 : make a bunch of tests runnable on msvs, and verify obj/exe contents in addition to flags #

Patch Set 33 : more msvs-runnable tests #

Patch Set 34 : rebase #

Patch Set 35 : rebase? #

Patch Set 36 : try a new checkout #

Patch Set 37 : rebase test #

Patch Set 38 : rebase test #

Patch Set 39 : remove unnecessary print #

Patch Set 40 : better place for normpath to remove need for $!-no-escape #

Total comments: 10

Patch Set 41 : fixes + remove all tests except one to make CL more managable #

Patch Set 42 : add missing test files and some _->- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -16 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +4 lines, -0 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 11 chunks +50 lines, -16 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 2 chunks +195 lines, -0 lines 0 comments Download
A test/win/compiler-flags/character-set.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +41 lines, -0 lines 0 comments Download
A test/win/compiler-flags/character-set-mbcs.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +11 lines, -0 lines 0 comments Download
A test/win/compiler-flags/character-set-unicode.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +15 lines, -0 lines 0 comments Download
A test/win/compiler-flags/hello.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +7 lines, -0 lines 0 comments Download
A test/win/gyptest-cl_character_set.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
scottmg
More tests in progress, but any thoughts before I do too much more in this ...
8 years, 10 months ago (2012-02-24 00:58:43 UTC) #1
scottmg
Alright, just the first 2 files are code, everything else is lots of test cases ...
8 years, 10 months ago (2012-02-25 00:57:32 UTC) #2
Nico
This looks like a great start. I haven't looked at the tests yet, and I ...
8 years, 10 months ago (2012-02-27 16:23:30 UTC) #3
scottmg
Thanks Nico! https://chromiumcodereview.appspot.com/9443044/diff/4104/buildbot/buildbot_run.py File buildbot/buildbot_run.py (right): https://chromiumcodereview.appspot.com/9443044/diff/4104/buildbot/buildbot_run.py#newcode82 buildbot/buildbot_run.py:82: retcode += GypTestFormat('ninja') On 2012/02/27 16:23:30, Nico ...
8 years, 10 months ago (2012-02-28 00:01:13 UTC) #4
Nico
https://chromiumcodereview.appspot.com/9443044/diff/24002/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9443044/diff/24002/pylib/gyp/generator/ninja.py#newcode223 pylib/gyp/generator/ninja.py:223: if path.startswith('$!'): Almost all of this CL looks really ...
8 years, 9 months ago (2012-02-29 19:44:18 UTC) #5
Nico
(Sorry the review is taking so long!)
8 years, 9 months ago (2012-02-29 19:44:51 UTC) #6
scottmg
http://chromiumcodereview.appspot.com/9443044/diff/24002/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://chromiumcodereview.appspot.com/9443044/diff/24002/pylib/gyp/generator/ninja.py#newcode223 pylib/gyp/generator/ninja.py:223: if path.startswith('$!'): On 2012/02/29 19:44:18, Nico wrote: > Almost ...
8 years, 9 months ago (2012-03-01 18:09:03 UTC) #7
cpu_(ooo_6.6-7.5)
I think the days of vs2008 are numbered, as in we should move to vs2010 ...
8 years, 9 months ago (2012-03-08 03:31:54 UTC) #8
scottmg
Fixed where windows-path-slash fixes happen (so there's no magic $! literal flag in msvs_emulation). Also, ...
8 years, 9 months ago (2012-03-12 22:33:29 UTC) #9
Nico
The code (and DEPS) changes look fantastic. I haven't looked through all the tests yet. ...
8 years, 9 months ago (2012-03-13 14:55:27 UTC) #10
scottmg
http://codereview.chromium.org/9443044/diff/41075/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/9443044/diff/41075/pylib/gyp/generator/ninja.py#newcode587 pylib/gyp/generator/ninja.py:587: extra_defines = [] On 2012/03/13 14:55:27, Nico wrote: > ...
8 years, 9 months ago (2012-03-14 00:57:56 UTC) #11
scottmg
On 2012/03/13 14:55:27, Nico wrote: > The code (and DEPS) changes look fantastic. I haven't ...
8 years, 9 months ago (2012-03-14 00:58:59 UTC) #12
Nico
8 years, 9 months ago (2012-03-14 01:21:08 UTC) #13
lgtm!

Powered by Google App Engine
This is Rietveld 408576698