Beginnings of some msvs_... emulation (windows ninja)

test/win/gyptest-cl_additional_options.py

+#!/usr/bin/env python
+
+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Make sure additional manual flags are extracted properly.
+"""
+
+import TestGyp
+
+import subprocess
+import sys
+
+if sys.platform == 'win32':
+  test = TestGyp.TestGyp(formats=['ninja'])

[Nico, 2012/02/29 19:44:18]

One thing that I did in the test/mac tests is that all tests run under ninja,
make, and xcode, and the test compares some property of the build executable.

That way, the test not only checks that ninja does what I think it should, but
it also makes sure it matches xcode's behavior. Is that something you could do
for msvc, too? At least in most cases? (I looked only through 3 tests so far, so
maybe you already have that.)

[scottmg, 2012/03/01 18:09:04]

Haven't done that. I'll go through them and see what can be tested in the C file
or binary instead. Maybe I should make these ones unit tests so they're faster
to run anyway.

+
+  CHDIR = 'compiler_flags'
+  test.run_gyp('additional-options.gyp', chdir=CHDIR)
+
+  ninja_file = test.built_file_path('obj/test_additional_none.ninja',
+      chdir=CHDIR)
+  # Just don't error out on build.
+
+  ninja_file = test.built_file_path('obj/test_additional_one.ninja',
+      chdir=CHDIR)
+  test.must_contain(ninja_file, 'cflags = /WEE')
+
+  ninja_file = test.built_file_path('obj/test_additional_few.ninja',
+      chdir=CHDIR)
+  test.must_contain(ninja_file, '/WEE')
+  test.must_contain(ninja_file, '/WAA')
+  test.must_contain(ninja_file, '/WOO')
+
+  test.pass_test()