GTK Keyboard Support for New Autofill

chrome/browser/autofill/autofill_popup_view.h

Index: chrome/browser/autofill/autofill_popup_view.h
diff --git a/chrome/browser/autofill/autofill_popup_view.h b/chrome/browser/autofill/autofill_popup_view.h
index 1ca890871d350d846787c2da28aa1f1c505318ef..f5557e0b5e13b2a3b57e9d4e2812941f59913536 100644
--- a/chrome/browser/autofill/autofill_popup_view.h
+++ b/chrome/browser/autofill/autofill_popup_view.h
@@ -54,6 +54,9 @@ class AutofillPopupView : public content::NotificationObserver {
   // Invalide the given row and redraw it.
   virtual void InvalidateRow(size_t row) = 0;
 
+  // Update the popup size to match the current Autofill values.
+  virtual void UpdatePopupSize() = 0;

[Ilya Sherman, 2012/03/15 20:10:56]

This method does not seem to be used.  If the motivation is to be able to resize
the popup once RemoveLine() is implemented, let's hold off on adding it until
then.

[csharp, 2012/03/21 15:32:28]

Done.

+
   AutofillExternalDelegate* external_delegate() { return external_delegate_; }
 
   const std::vector<string16>& autofill_values() const {
@@ -75,6 +78,18 @@ class AutofillPopupView : public content::NotificationObserver {
   // Change which line is currently selected by the user.
   void SetSelectedLine(int selected_line);
 
+  // Increase the selected line by 1, properly handling wrapping.
+  void IncreaseSelectedLine();

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "SelectNextLine()"?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // Decrease the selected line by 1, properly handling wrapping.
+  void DecreaseSelectedLine();

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "SelectPreviousLine()"?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // The user has choosen line |line|.
+  void ChooseLine(int line);

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "AcceptLine()", to match the use of "select" and "accept"
elsewhere.

[Ilya Sherman, 2012/03/15 20:10:56]

Can we remove the |line| parameter, and always accept the currently selected
line?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // The user has removed a suggestion.
+  void RemoveLine(int line);
+
  private:
   // content::NotificationObserver method override.
   virtual void Observe(int type,