GTK Keyboard Support for New Autofill

chrome/browser/autofill/autofill_popup_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_VIEW_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_VIEW_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 36 matching lines @@
   // Display the autofill popup and fill it in with the values passed in.
   // Platform-dependent work.
   virtual void ShowInternal() = 0;
 
   // Hide the popup from view. Platform-dependent work.
   virtual void HideInternal() = 0;
 
   // Invalide the given row and redraw it.
   virtual void InvalidateRow(size_t row) = 0;
 
+  // Update the popup size to match the current Autofill values.
+  virtual void UpdatePopupSize() = 0;

[Ilya Sherman, 2012/03/15 20:10:56]

This method does not seem to be used.  If the motivation is to be able to resize
the popup once RemoveLine() is implemented, let's hold off on adding it until
then.

[csharp, 2012/03/21 15:32:28]

Done.

+
   AutofillExternalDelegate* external_delegate() { return external_delegate_; }
 
   const std::vector<string16>& autofill_values() const {
     return autofill_values_;
   }
   const std::vector<string16>& autofill_labels() const {
     return autofill_labels_;
   }
   const std::vector<string16>& autofill_icons() const {
     return autofill_icons_;
   }
   const std::vector<int>& autofill_unique_ids() const {
     return autofill_unique_ids_;
   }
   int separator_index() const { return separator_index_; }
 
   int selected_line() const { return selected_line_; }
 
   // Change which line is currently selected by the user.
   void SetSelectedLine(int selected_line);
 
+  // Increase the selected line by 1, properly handling wrapping.
+  void IncreaseSelectedLine();

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "SelectNextLine()"?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // Decrease the selected line by 1, properly handling wrapping.
+  void DecreaseSelectedLine();

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "SelectPreviousLine()"?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // The user has choosen line |line|.
+  void ChooseLine(int line);

[Ilya Sherman, 2012/03/15 20:10:56]

nit: Perhaps "AcceptLine()", to match the use of "select" and "accept"
elsewhere.

[Ilya Sherman, 2012/03/15 20:10:56]

Can we remove the |line| parameter, and always accept the currently selected
line?

[csharp, 2012/03/21 15:32:28]

Done.

+
+  // The user has removed a suggestion.
+  void RemoveLine(int line);
+
  private:
   // content::NotificationObserver method override.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // A scoped container for notification registries.
   content::NotificationRegistrar registrar_;
 
   AutofillExternalDelegate* external_delegate_;
@@ skipping 10 matching lines @@
   // The location of the separator index (which separates the returned values
   // from the Autofill options).
   int separator_index_;
 
   // The line that is currently selected by the user.
   // -1 indicates that no line is currently selected.
   int selected_line_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_VIEW_H_