Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 9432013: Add presubmit checks and watchlist for FFmpeg repo. (Closed)

Created:
8 years, 10 months ago by DaleCurtis
Modified:
8 years, 10 months ago
CC:
chromium-reviews, acolwell+watch_chromium.org, dalecurtis+watch_chromium.org, fischman+watch_chromium.org, ihf+watch_chromium.org, scherkus+watch_chromium.org
Base URL:
ssh://gerrit.chromium.org:29418/chromium/third_party/ffmpeg.git@master
Visibility:
Public.

Description

Add presubmit checks and watchlist for FFmpeg repo. Presubmit does the following: - Ensures users don't commit to the Subversion repository. - Reminds users to update the README when they make changes. - Reminds users that the Windows DLLs, Subversion repository, and DEPS files need manual updating. BUG=110775 TEST=Checked this commit.

Patch Set 1 : Watchlist. #

Total comments: 11

Patch Set 2 : Review fixes. #

Total comments: 3

Patch Set 3 : Remove status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -3 lines) Patch
A PRESUBMIT.py View 1 1 chunk +82 lines, -0 lines 0 comments Download
M codereview.settings View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
8 years, 10 months ago (2012-02-22 00:50:34 UTC) #1
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/9432013/diff/3001/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/9432013/diff/3001/PRESUBMIT.py#newcode40 PRESUBMIT.py:40: 'Commits to the FFmpeg repository must be made through ...
8 years, 10 months ago (2012-02-22 01:22:00 UTC) #2
DaleCurtis
https://chromiumcodereview.appspot.com/9432013/diff/3001/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/9432013/diff/3001/PRESUBMIT.py#newcode40 PRESUBMIT.py:40: 'Commits to the FFmpeg repository must be made through ...
8 years, 10 months ago (2012-02-22 20:15:13 UTC) #3
Ami GONE FROM CHROMIUM
LGTM https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings File codereview.settings (right): https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings#newcode3 codereview.settings:3: CC_LIST: chromium-reviews@chromium.org, feature-media-reviews@chromium.org I wonder if (a new) ...
8 years, 10 months ago (2012-02-22 20:57:26 UTC) #4
scherkus (not reviewing)
one comment but lgtm https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings File codereview.settings (right): https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings#newcode4 codereview.settings:4: STATUS: http://chromium-status.appspot.com/status AFAIK this will ...
8 years, 10 months ago (2012-02-23 21:46:56 UTC) #5
DaleCurtis
8 years, 10 months ago (2012-02-23 21:49:39 UTC) #6
https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings
File codereview.settings (right):

https://chromiumcodereview.appspot.com/9432013/diff/6/codereview.settings#new...
codereview.settings:4: STATUS: http://chromium-status.appspot.com/status
On 2012/02/23 21:46:56, scherkus wrote:
> AFAIK this will prevent us from committing if the main tree is closed -- may
> consider removing in the future

Done.

Powered by Google App Engine
This is Rietveld 408576698