Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 9429058: Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 10 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken https://bugs.webkit.org/show_bug.cgi?id=78385 <rdar://problem/10832932> Reviewed by Simon Fraser. Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full; we can't skip rebuilding the layout attributes, just walking the tree to acquire the positioning lists (invalidation of positioning lists is already covered by textDOMChanged). Test: svg/text/tspan-dynamic-positioning.svg * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded): Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout. * platform/chromium/test_expectations.txt: * platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added. * platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added. * svg/text/tspan-dynamic-positioning.svg: Added. TBR=timothy_horton@apple.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=108519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M LayoutTests/platform/chromium/test_expectations.txt View 2 chunks +6 lines, -0 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/tspan-dynamic-positioning-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/tspan-dynamic-positioning-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/tspan-dynamic-positioning.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Evan Martin
8 years, 10 months ago (2012-02-22 18:37:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698