Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp - Issue 9429058: Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp

Issue 9429058: Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp

===================================================================

--- Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp (revision 108518)

+++ Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp (working copy)

@@ -79,12 +79,12 @@

bool SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded(RenderSVGText* textRoot)

{

ASSERT(textRoot);

- if (!m_textPositions.isEmpty())

- return m_textLength;

- m_textLength = 0;

- const UChar* lastCharacter = 0;

- collectTextPositioningElements(textRoot, lastCharacter);

+ if (m_textPositions.isEmpty()) {

+ m_textLength = 0;

+ const UChar* lastCharacter = 0;

+ collectTextPositioningElements(textRoot, lastCharacter);

+ }

m_characterDataMap.clear();

if (!m_textLength)

« no previous file with comments | « LayoutTests/svg/text/tspan-dynamic-positioning.svg ('k') | no next file » | no next file with comments »