Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 9429015: Added no argument constructor support to external arrays. (Closed)

Created:
8 years, 10 months ago by ioseb
Modified:
8 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added no argument constructor support to external arrays. ArrayType.call({}), ArrayType.apply({}) and new ArrayType() are all supported now. Modified existing no arg constructor test to assertDoesNotThrow(). Added number of new different tests. Original issue: http://code.google.com/p/v8/issues/detail?id=1497 Contributed by ioseb.dzmanashvili@gmail.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M src/d8.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M test/mjsunit/external-array.js View 2 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ioseb
8 years, 10 months ago (2012-02-21 22:42:54 UTC) #1
ioseb
8 years, 10 months ago (2012-02-24 11:04:39 UTC) #2
rossberg
Ioseb, thanks for this patch. Typed array support in d8 has been vastly improved lately. ...
8 years, 5 months ago (2012-06-29 15:28:40 UTC) #3
ioseb
8 years, 5 months ago (2012-06-29 15:49:00 UTC) #4
Hi Andreas,

You are welcome! Only reason i think it must be supported is that typed arrays
are functions(as was stated in initial issue:
http://code.google.com/p/v8/issues/detail?id=1497) and to my knowledge all JS
functions support these methods, additionally .call() and .apply() methods are
supported in FF. Safari is different though and typed arrays are objects instead
of functions there. But, when i was investigated deeper found several related
issues(details are in this comment:
http://code.google.com/p/v8/issues/detail?id=1497#c5) and gave up with this
patch because i'm not 100% sure how this feature needs to be implemented in
consistent way.

ioseb

On 2012/06/29 15:28:40, rossberg wrote:
> Ioseb, thanks for this patch. Typed array support in d8 has been vastly
improved
> lately. However, I did not incorporate the functionality you implemented in
this
> patch, because it is not covered by the actual typed array spec. Any
particular
> reason why you think this should be supported?

Powered by Google App Engine
This is Rietveld 408576698