Issue 9429005: MIPS: Added support for Loongson architectures.

Issue 9429005: MIPS: Added support for Loongson architectures. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 9 months ago

Reviewers:
kisg, Paul Lind, Kevin Millikin (Google), Yang, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Added support for Loongson architectures. The added target arch variant support refers to the LOONGSON architectures based on MIPS-III, which predates and is a subset of the mips32r2 and r1 architectures. BUG= TEST=

Patch Set 1 #

Patch Set 2 : Added loongson variant to the gyp system. #

Total comments: 3

Patch Set 3 : Updated arch variant-related names based on review comments and style guide. #

Patch Set 4 : Fixed arch variant constant naming in cctest files. #

Patch Set 5 : rebased on r10833. #

Patch Set 6 : rebased on r10858. #

Patch Set 7 : rebased on r10962. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+338 lines, -131 lines)			Patch
M	SConstruct	View	1 2 3 4 5 6	7 chunks	+19 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	build/mipsu.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/assembler-mips.cc	View	1 2	7 chunks	+10 lines, -10 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 2 3 4 5 6	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/mips/constants-mips.h	View	1 2	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/mips/disasm-mips.cc	View	1 2	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	1 2 3 4 5 6	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 2 3 4 5 6	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 2 3 4 5 6	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 2 3 4 5 6	10 chunks	+163 lines, -13 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 2 3 4 5 6	9 chunks	+13 lines, -13 lines	0 comments	Download
M	test/cctest/test-assembler-mips.cc	View	1 2 3	3 chunks	+15 lines, -10 lines	0 comments	Download
M	test/cctest/test-disasm-mips.cc	View	1 2 3	3 chunks	+53 lines, -49 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Yang

Drive-by comment. https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h File src/mips/constants-mips.h (right): https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h#newcode42 src/mips/constants-mips.h:42: enum arch_variants {mips32r2, mips32r1, loongson}; I strongly ...

8 years, 10 months ago (2012-02-22 10:58:14 UTC) #2

Kevin Millikin (Google)

https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h File src/mips/constants-mips.h (right): https://chromiumcodereview.appspot.com/9429005/diff/3001/src/mips/constants-mips.h#newcode42 src/mips/constants-mips.h:42: enum arch_variants {mips32r2, mips32r1, loongson}; Good catch. The style ...

8 years, 10 months ago (2012-02-22 11:29:38 UTC) #3

kalmard

Thanks for the review. I updated the variable and type names to match the style ...

8 years, 10 months ago (2012-02-23 13:23:47 UTC) #4

Yang

8 years, 9 months ago (2012-03-13 16:20:49 UTC) #8

On 2012/03/08 11:25:29, kalmard wrote:
> rebased on r10962.

Landed as r11032.

Expand Messages | Collapse Messages