Issue 9426030: Mac: Enable WebAppShortcutCreatorTest.CreateShortcut unit test

Issue 9426030: Mac: Enable WebAppShortcutCreatorTest.CreateShortcut unit test (Closed)

Created:
8 years, 10 months ago by jeremy

Modified:
8 years, 9 months ago

Reviewers:
sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mac: Enable WebAppShortcutCreatorTest.CreateShortcut unit test * Mock out code to reveal generated app bundle in Finder. * Change how we fill in the template plist to a variable substitution model. * Clean app_mode-Info.plist to remove unneeded keys. BUG=112651 TEST=WebAppShortcutCreatorTest.CreateShortcut should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124174

Patch Set 1 #

Patch Set 2 : Whitespace fixes #

Total comments: 2

Patch Set 3 : Patch for landing #

Patch Set 4 : Patch for landing #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -40 lines)			Patch
M	chrome/app/app_mode-Info.plist	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/app/app_mode_loader_mac.mm	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac.mm	View	1 2	3 chunks	+47 lines, -19 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_mac_unittest.mm	View	1 2 3	4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/common/mac/app_mode_common.h	View	1 2	3 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/common/mac/app_mode_common.mm	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jeremy

Do the info.plist keys look right to you? Anything else we need to add in ...

8 years, 10 months ago (2012-02-20 08:23:08 UTC) #1

sail

lgtm https://chromiumcodereview.appspot.com/9426030/diff/2001/chrome/browser/web_applications/web_app_mac_unittest.mm File chrome/browser/web_applications/web_app_mac_unittest.mm (right): https://chromiumcodereview.appspot.com/9426030/diff/2001/chrome/browser/web_applications/web_app_mac_unittest.mm#newcode52 chrome/browser/web_applications/web_app_mac_unittest.mm:52: EXPECT_CALL(shortcut_creator, RevealGeneratedBundleInFinder(dst_path)); why do you need this?

8 years, 10 months ago (2012-02-20 17:47:10 UTC) #2

jeremy

https://chromiumcodereview.appspot.com/9426030/diff/2001/chrome/browser/web_applications/web_app_mac_unittest.mm File chrome/browser/web_applications/web_app_mac_unittest.mm (right): https://chromiumcodereview.appspot.com/9426030/diff/2001/chrome/browser/web_applications/web_app_mac_unittest.mm#newcode52 chrome/browser/web_applications/web_app_mac_unittest.mm:52: EXPECT_CALL(shortcut_creator, RevealGeneratedBundleInFinder(dst_path)); To make sure that the function is ...

8 years, 10 months ago (2012-02-21 13:22:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/9426030/12001

8 years, 9 months ago (2012-02-29 10:03:48 UTC) #4

Change committed as 124174

Expand Messages | Collapse Messages