Enable test-api/TurnOnAccessCheckAndRecompile and change it so it can't cause a GC.

Enable test-api/TurnOnAccessCheckAndRecompile and change it so it can't cause a GC.

A GC in the access check callbacks NamedSecurityCallback and IndexedSecurityCallback
violates the contract about these callbacks.

Added a EXTERNAL VMState scope around the call to FailedAccessCheckCallback to be
consistent with the other callback invocations.

BUG=v8:1952
TEST=cctest/test-api/TurnOnAccessCheckAndRecompile
Committed: https://code.google.com/p/v8/source/detail?r=10764

[Vyacheslav Egorov (Chromium), 2012-02-20 14:28:13]

LGTM with comments addressed.

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11053: const char* a = "a";
static const char* kPropertyA

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11054: const char* h = "h";
static const char* kPropertyB

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11063: return !(strcmp(a, buf) == 0 || strcmp(h, buf) ==
0);
->IsEqualTo(CStrVector(kPropertyA))

?

[fschneider, 2012-02-22 11:27:50]

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11053: const char* a = "a";
On 2012/02/20 14:28:13, Vyacheslav Egorov wrote:
> static const char* kPropertyA

Done.

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11054: const char* h = "h";
On 2012/02/20 14:28:13, Vyacheslav Egorov wrote:
> static const char* kPropertyB

Done.

https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc...
test/cctest/test-api.cc:11063: return !(strcmp(a, buf) == 0 || strcmp(h, buf) ==
0);
On 2012/02/20 14:28:13, Vyacheslav Egorov wrote:
> ->IsEqualTo(CStrVector(kPropertyA))
> 
> ?

Done.