Enable test-api/TurnOnAccessCheckAndRecompile and change it so it can't cause a GC.

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11032 matching lines @@
 
   // Failing access check to function call results in exception.
   CHECK(g1->Call(global, 0, NULL).IsEmpty());
   CHECK(g2->Call(global, 0, NULL).IsEmpty());
 
   // No failing access check when just returning a constant.
   CHECK(h->Call(global, 0, NULL)->Equals(v8_num(1)));
 }
 
 
-v8::Handle<v8::String> a;
-v8::Handle<v8::String> h;
+const char* a = "a";

[Vyacheslav Egorov (Chromium), 2012/02/20 14:28:13]

static const char* kPropertyA

[fschneider, 2012/02/22 11:27:50]

Done.

+const char* h = "h";

[Vyacheslav Egorov (Chromium), 2012/02/20 14:28:13]

static const char* kPropertyB

[fschneider, 2012/02/22 11:27:50]

Done.

 
 static bool NamedGetAccessBlockAandH(Local<v8::Object> obj,
                                        Local<Value> name,
                                        v8::AccessType type,
                                        Local<Value> data) {
-  return !(name->Equals(a) || name->Equals(h));
+  if (!name->IsString()) return false;
+  char buf[10];
+  Local<String>::Cast(name)->WriteAscii(buf, 0, 9);
+  return !(strcmp(a, buf) == 0 || strcmp(h, buf) == 0);

[Vyacheslav Egorov (Chromium), 2012/02/20 14:28:13]

->IsEqualTo(CStrVector(kPropertyA))

?

[fschneider, 2012/02/22 11:27:50]

Done.

 }
 
 
-// TODO(1952): Enable this test for threading test once the underlying bug is
-// fixed.
-TEST(TurnOnAccessCheckAndRecompile) {
+THREADED_TEST(TurnOnAccessCheckAndRecompile) {
   v8::HandleScope handle_scope;
 
   // Create an environment with access check to the global object disabled by
   // default. When the registered access checker will block access to properties
-  // a and h
-  a = v8_str("a");
-  h = v8_str("h");
+  // a and h.
   v8::Handle<v8::ObjectTemplate> global_template = v8::ObjectTemplate::New();
   global_template->SetAccessCheckCallbacks(NamedGetAccessBlockAandH,
                                            IndexedGetAccessBlocker,
                                            v8::Handle<v8::Value>(),
                                            false);
   v8::Persistent<Context> context = Context::New(NULL, global_template);
   Context::Scope context_scope(context);
 
   // Set up a property and a number of functions.
   context->Global()->Set(v8_str("a"), v8_num(1));
@@ skipping 5008 matching lines @@
   CompileRun("throw 'exception';");
 }
 
 
 TEST(CallCompletedCallbackTwoExceptions) {
   v8::HandleScope scope;
   LocalContext env;
   v8::V8::AddCallCompletedCallback(CallCompletedCallbackException);
   CompileRun("throw 'first exception';");
 }