Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 9421016: Change EventGenerator to take a RootWindow at construction instead of just assuming one via RootWin… (Closed)

Created:
8 years, 10 months ago by Ben Goodger (Google)
Modified:
8 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Change EventGenerator to take a RootWindow at construction instead of just assuming one via RootWindow::GetInstance(). http://crbug.com/112131 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122829

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -63 lines) Patch
M ash/accelerators/accelerator_filter_unittest.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 3 7 chunks +12 lines, -7 lines 0 comments Download
M ash/ime/input_method_event_filter_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/activation_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/root_window_event_filter_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 3 7 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 10 months ago (2012-02-18 00:46:45 UTC) #1
sky
8 years, 10 months ago (2012-02-18 00:56:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698