Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: icu.gyp

Issue 9420032: Take care of two Clang warnings. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: final patch Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.chromium ('k') | patches/clang.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
===================================================================
--- icu.gyp (revision 122414)
+++ icu.gyp (working copy)
@@ -333,10 +333,6 @@
# the header should use U_NAMESPACE_BEGIN instead.
# http://bugs.icu-project.org/trac/ticket/9054
'-Wno-header-hygiene',
- # ICU does some tricky array allocation that trips over
- # -Warray-bounds. It seems to be harmless, see
- # http://crbug.com/84851.
- '-Wno-array-bounds',
# Looks like a real issue, see http://crbug.com/114660
'-Wno-return-type-c-linkage',
],
@@ -346,7 +342,6 @@
'-Wno-logical-op-parentheses',
'-Wno-tautological-compare',
'-Wno-header-hygiene',
- '-Wno-array-bounds',
'-Wno-return-type-c-linkage',
],
}],
« no previous file with comments | « README.chromium ('k') | patches/clang.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698