Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: icu.gyp

Issue 9420032: Take care of two Clang warnings. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: final patch Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « README.chromium ('k') | patches/clang.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_icu%': 0, 7 'use_system_icu%': 0,
8 'icu_use_data_file_flag%': 0, 8 'icu_use_data_file_flag%': 0,
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 # ICU uses its own deprecated functions. 326 # ICU uses its own deprecated functions.
327 '-Wno-deprecated-declarations', 327 '-Wno-deprecated-declarations',
328 # ICU prefers `a && b || c` over `(a && b) || c`. 328 # ICU prefers `a && b || c` over `(a && b) || c`.
329 '-Wno-logical-op-parentheses', 329 '-Wno-logical-op-parentheses',
330 # ICU has some `unsigned < 0` checks. 330 # ICU has some `unsigned < 0` checks.
331 '-Wno-tautological-compare', 331 '-Wno-tautological-compare',
332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug, 332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
333 # the header should use U_NAMESPACE_BEGIN instead. 333 # the header should use U_NAMESPACE_BEGIN instead.
334 # http://bugs.icu-project.org/trac/ticket/9054 334 # http://bugs.icu-project.org/trac/ticket/9054
335 '-Wno-header-hygiene', 335 '-Wno-header-hygiene',
336 # ICU does some tricky array allocation that trips over
337 # -Warray-bounds. It seems to be harmless, see
338 # http://crbug.com/84851.
339 '-Wno-array-bounds',
340 # Looks like a real issue, see http://crbug.com/114660 336 # Looks like a real issue, see http://crbug.com/114660
341 '-Wno-return-type-c-linkage', 337 '-Wno-return-type-c-linkage',
342 ], 338 ],
343 }, 339 },
344 'cflags': [ 340 'cflags': [
345 '-Wno-deprecated-declarations', 341 '-Wno-deprecated-declarations',
346 '-Wno-logical-op-parentheses', 342 '-Wno-logical-op-parentheses',
347 '-Wno-tautological-compare', 343 '-Wno-tautological-compare',
348 '-Wno-header-hygiene', 344 '-Wno-header-hygiene',
349 '-Wno-array-bounds',
350 '-Wno-return-type-c-linkage', 345 '-Wno-return-type-c-linkage',
351 ], 346 ],
352 }], 347 }],
353 ], 348 ],
354 }, 349 },
355 { 350 {
356 'target_name': 'icuuc', 351 'target_name': 'icuuc',
357 'type': '<(component)', 352 'type': '<(component)',
358 'sources': [ 353 'sources': [
359 'source/common/bmpset.cpp', 354 'source/common/bmpset.cpp',
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 { 647 {
653 'target_name': 'icuuc', 648 'target_name': 'icuuc',
654 'type': 'none', 649 'type': 'none',
655 'dependencies': ['system_icu'], 650 'dependencies': ['system_icu'],
656 'export_dependent_settings': ['system_icu'], 651 'export_dependent_settings': ['system_icu'],
657 }, 652 },
658 ], 653 ],
659 }], 654 }],
660 ], 655 ],
661 } 656 }
OLDNEW
« no previous file with comments | « README.chromium ('k') | patches/clang.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698