Take care of two Clang warnings.

Take care of two Clang warnings.

- decNumber.c has several places where Clang complains about array index
  out-of-bounds error. According to udecnum.h, it's done on purpose because
  the array in question (lsu) is followed by additional spaces for digits.
  So, we suppress 'array-bounds' warning with clang-specific pragmas.
  GCC 4.6 also complains about this, but it's hard to make GCC 4.4 and
  GCC 4.6 happy at the same time without getting too ugly because GCC 4.4 
  does not support 'pragra diagnostic {push|pop}'

  See http://bugs.icu-project.org/trac/ticket/8954

- colldata.cpp copies an array of UnicodeString's with memcpy. It's changed to
  to use a for-loop, instead. The upstream ToT has fixed this. 

BUG=84851, 92756
TEST=Compile with Clang and it does not complain any more in devNumber.c and colldata.cpp
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122423

[jungshik at Google, 2012-02-17 00:23:41]

clang is happy with this CL. (patch set 2)

gcc 4.6 gives a similar warning and I've tried to make both gcc 4.6 and clang
happy by using

#if defined(__GNUC__) || defined(__clang__)
#prgma GCC diag ..... 

gcc 4.6 does not allow pragrma inside a function. So, I have to move pragma's
out of a function. I haven't tried it yet with clang.

[Nico, 2012-02-17 00:29:37]

Thanks!

Can you remove the -Wno-array-bounds from icu.gyp again? (I added it earlier
today.)

http://codereview.chromium.org/9420032/diff/2002/source/i18n/decNumber.c
File source/i18n/decNumber.c (right):

http://codereview.chromium.org/9420032/diff/2002/source/i18n/decNumber.c#newc...
source/i18n/decNumber.c:1505: #ifdef __clang__
You don't need the #ifdef, compilers are supposed to ignore #pragmas they don't
understand.

[jungshik at Google, 2012-02-17 01:06:58]

Nico, can you take a look at patch set #3?  

#pragma GCC diagnostic push
#pragma GCC diagnostic pop

doesn't work with GCC 4.4. So, I just used 'clang' instead of GCC.

[Nico, 2012-02-17 01:10:51]

lgtm with updated patch file

thanks!

http://codereview.chromium.org/9420032/diff/1006/patches/clang.patch
File patches/clang.patch (right):

http://codereview.chromium.org/9420032/diff/1006/patches/clang.patch#newcode69
patches/clang.patch:69: +      #ifdef __clang__
Looks like the patch file still has the old change