Issue 9419043: Revert 122412 - Enabled pressing TAB to traverse through the Omnibox results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9419043: Revert 122412 - Enabled pressing TAB to traverse through the Omnibox results (Closed)

Created:
8 years, 10 months ago by Lei Zhang

Modified:
8 years, 10 months ago

Reviewers:
sail

CC:
chromium-reviews, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 122412 - Enabled pressing TAB to traverse through the Omnibox results Landing patch for aaron.randolph: http://codereview.chromium.org/9309099/ BUG=57748, 76278, 77662, 80934, 84420 TEST= Review URL: https://chromiumcodereview.appspot.com/9417032 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122472

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+356 lines, -958 lines)			Patch
M	AUTHORS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.h	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View	5 chunks	+5 lines, -49 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View	7 chunks	+19 lines, -53 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_unittest.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.h	View	6 chunks	+0 lines, -37 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View	3 chunks	+3 lines, -77 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_model.h	View	6 chunks	+14 lines, -21 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_model.cc	View	5 chunks	+59 lines, -26 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_unittest.cc	View	10 chunks	+16 lines, -133 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.h	View	4 chunks	+9 lines, -22 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.cc	View	9 chunks	+60 lines, -110 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider_unittest.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View	8 chunks	+30 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	View	5 chunks	+18 lines, -28 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View	5 chunks	+34 lines, -119 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc	View	8 chunks	+19 lines, -28 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_result_view.h	View	5 chunks	+2 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc	View	7 chunks	+17 lines, -98 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	3 chunks	+9 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_win.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_win.cc	View	4 chunks	+16 lines, -20 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_mac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/keycodes/keyboard_codes_posix.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

8 years, 10 months ago (2012-02-17 09:03:30 UTC) #2

Broke CrOS bots. They've been red for a while.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS/b...

Expand Messages | Collapse Messages