Revert 122412 - Enabled pressing TAB to traverse through the Omnibox results

chrome/browser/autocomplete/autocomplete_edit.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/metrics/histogram.h"
@@ skipping 155 matching lines @@
   has_temporary_text_ = false;
 }
 
 void AutocompleteEditModel::FinalizeInstantQuery(
     const string16& input_text,
     const string16& suggest_text,
     bool skip_inline_autocomplete) {
   if (skip_inline_autocomplete) {
     const string16 final_text = input_text + suggest_text;
     view_->OnBeforePossibleChange();
-    view_->SetWindowTextAndCaretPos(final_text, final_text.length(), false,
-        false);
+    view_->SetWindowTextAndCaretPos(final_text, final_text.length());
     view_->OnAfterPossibleChange();
   } else if (popup_->IsOpen()) {
     SearchProvider* search_provider =
         autocomplete_controller_->search_provider();
     // There may be no providers during testing; guard against that.
     if (search_provider)
       search_provider->FinalizeInstantQuery(input_text, suggest_text);
   }
 }
 
@@ skipping 212 matching lines @@
 }
 
 void AutocompleteEditModel::Revert() {
   SetInputInProgress(false);
   paste_state_ = NONE;
   InternalSetUserText(string16());
   keyword_.clear();
   is_keyword_hint_ = false;
   has_temporary_text_ = false;
   view_->SetWindowTextAndCaretPos(permanent_text_,
-                                  has_focus_ ? permanent_text_.length() : 0,
-                                  false, true);
+                                  has_focus_ ? permanent_text_.length() : 0);
   NetworkActionPredictor* network_action_predictor =
       NetworkActionPredictorFactory::GetForProfile(profile_);
   if (network_action_predictor)
     network_action_predictor->ClearTransitionalMatches();
 }
 
 void AutocompleteEditModel::StartAutocomplete(
     bool has_selected_text,
     bool prevent_inline_autocomplete) const {
-  ClearPopupKeywordMode();
-
   bool keyword_is_selected = KeywordIsSelected();
   popup_->SetHoveredLine(AutocompletePopupModel::kNoMatch);
   // We don't explicitly clear AutocompletePopupModel::manually_selected_match,
   // as Start ends up invoking AutocompletePopupModel::OnResultChanged which
   // clears it.
   autocomplete_controller_->Start(
       user_text_, GetDesiredTLD(),
       prevent_inline_autocomplete || just_deleted_text_ ||
       (has_selected_text && inline_autocomplete_text_.empty()) ||
       (paste_state_ != NONE), keyword_is_selected,
@@ skipping 182 matching lines @@
 
   InstantController* instant = controller_->GetInstant();
   if (instant && !popup_->IsOpen())
     instant->DestroyPreviewContents();
   in_revert_ = false;
 }
 
 bool AutocompleteEditModel::AcceptKeyword() {
   DCHECK(is_keyword_hint_ && !keyword_.empty());
 
-  autocomplete_controller_->Stop(false);
+  view_->OnBeforePossibleChange();
+  view_->SetWindowTextAndCaretPos(string16(), 0);
   is_keyword_hint_ = false;
-
-  if (popup_->IsOpen())
-    popup_->SetSelectedLineState(AutocompletePopupModel::KEYWORD);
-  else
-    StartAutocomplete(false, true);
-
-  // Ensure the current selection is saved before showing keyword mode
-  // so that moving to another line and then reverting the text will restore
-  // the current state properly.
-  view_->OnTemporaryTextMaybeChanged(
-      DisplayTextFromUserText(CurrentMatch().fill_into_edit),
-      !has_temporary_text_);
-  has_temporary_text_ = true;
-
+  view_->OnAfterPossibleChange();
+  just_deleted_text_ = false;  // OnAfterPossibleChange() erroneously sets this
+                               // since the edit contents have disappeared.  It
+                               // doesn't really matter, but we clear it to be
+                               // consistent.
   content::RecordAction(UserMetricsAction("AcceptedKeywordHint"));
   return true;
 }
 
 void AutocompleteEditModel::ClearKeyword(const string16& visible_text) {
-  autocomplete_controller_->Stop(false);
-  ClearPopupKeywordMode();
-
+  view_->OnBeforePossibleChange();
   const string16 window_text(keyword_ + visible_text);
-
-  // Only reset the result if the edit text has changed since the
-  // keyword was accepted, or if the popup is closed.
-  if (just_deleted_text_ || !visible_text.empty() || !popup_->IsOpen()) {
-    view_->OnBeforePossibleChange();
-    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length(),
-        false, false);
-    keyword_.clear();
-    is_keyword_hint_ = false;
-    view_->OnAfterPossibleChange();
-    just_deleted_text_ = true;  // OnAfterPossibleChange() fails to clear this
-                                // since the edit contents have actually grown
-                                // longer.
-  } else {
-    is_keyword_hint_ = true;
-    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length(),
-        false, true);
-  }
+  view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length());
+  keyword_.clear();
+  is_keyword_hint_ = false;
+  view_->OnAfterPossibleChange();
+  just_deleted_text_ = true;  // OnAfterPossibleChange() fails to clear this
+                              // since the edit contents have actually grown
+                              // longer.
 }
 
 const AutocompleteResult& AutocompleteEditModel::result() const {
   return autocomplete_controller_->result();
 }
 
 void AutocompleteEditModel::OnSetFocus(bool control_down) {
   has_focus_ = true;
   control_key_state_ = control_down ? DOWN_WITHOUT_CHANGE : UP;
 
@@ skipping 242 matching lines @@
             match->fill_into_edit.substr(match->inline_autocomplete_offset);
       }
 
       if (!prerender::IsOmniboxEnabled(profile_))
         DoPreconnect(*match);
 
       // We could prefetch the alternate nav URL, if any, but because there
       // can be many of these as a user types an initial series of characters,
       // the OS DNS cache could suffer eviction problems for minimal gain.
 
-      is_keyword_hint = match->GetKeyword(&keyword);
+      is_keyword_hint = popup_->GetKeywordForMatch(*match, &keyword);
     }
-
     popup_->OnResultChanged();
     OnPopupDataChanged(inline_autocomplete_text, NULL, keyword,
                        is_keyword_hint);
   } else {
     popup_->OnResultChanged();
   }
 
   if (popup_->IsOpen()) {
     PopupBoundsChangedTo(popup_->view()->GetTargetBounds());
   } else if (was_open) {
@@ skipping 12 matching lines @@
 void AutocompleteEditModel::InternalSetUserText(const string16& text) {
   user_text_ = text;
   just_deleted_text_ = false;
   inline_autocomplete_text_.clear();
 }
 
 bool AutocompleteEditModel::KeywordIsSelected() const {
   return !is_keyword_hint_ && !keyword_.empty();
 }
 
-void AutocompleteEditModel::ClearPopupKeywordMode() const {
-  if (popup_->IsOpen() &&
-      popup_->selected_line_state() == AutocompletePopupModel::KEYWORD)
-    popup_->SetSelectedLineState(AutocompletePopupModel::NORMAL);
-}
-
 string16 AutocompleteEditModel::DisplayTextFromUserText(
     const string16& text) const {
   return KeywordIsSelected() ?
       KeywordProvider::SplitReplacementStringFromInput(text, false) : text;
 }
 
 string16 AutocompleteEditModel::UserTextFromDisplayText(
     const string16& text) const {
   return KeywordIsSelected() ? (keyword_ + char16(' ') + text) : text;
 }
@@ skipping 79 matching lines @@
                              old_user_text.length() - caret_position + 1)) {
     return false;
   }
 
   // Then check if the text before the inserted space matches a keyword.
   string16 keyword;
   TrimWhitespace(new_user_text.substr(0, caret_position - 1),
                  TRIM_LEADING, &keyword);
 
   // Only allow exact keyword match if |keyword| represents a keyword hint.
-  return keyword.length() &&
-      !autocomplete_controller_->keyword_provider()->
-          GetKeywordForText(keyword).empty();
+  return keyword.length() && popup_->GetKeywordForText(keyword, &keyword);
 }
 
 bool AutocompleteEditModel::DoInstant(const AutocompleteMatch& match,
                                       string16* suggested_text) {
   DCHECK(suggested_text);
 
   if (in_revert_)
     return false;
 
   InstantController* instant = controller_->GetInstant();
@@ skipping 55 matching lines @@
 //  static
 bool AutocompleteEditModel::IsSpaceCharForAcceptingKeyword(wchar_t c) {
   switch (c) {
     case 0x0020:  // Space
     case 0x3000:  // Ideographic Space
       return true;
     default:
       return false;
   }
 }