Move creation of BrowserContext objects that live in content to content, instead of depending on th…

Move creation of BrowserContext objects that live in content to content, instead of depending on the embedder. Apart from allowing us to hide more of content from embedders, it simplifies the work that every embedder has to do (see the change the shell_browser_context.cc as an example).

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122521
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122768

[jam, 2012-02-17 01:01:45]

Sorry this seems so large; I had to move all these 5 objects together because
they depended on QuotaManager. Most of the changes should be deleting code, or
changing profile->X to BrowserContext::GetX.

[jam, 2012-02-17 16:09:25]

erg->Avi

[jam, 2012-02-17 16:16:58]

Avi->main reviewer
Miranda->chrome/browser/profiles

[Avi (use Gerrit), 2012-02-17 16:25:08]

lgtm

http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.h (right):

http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.h:184: // content::BrowserContext implementation
------------------------------------
This comment marks the end of the implementation; remove it too.

http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
File chrome/test/base/testing_profile.h (right):

http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
chrome/test/base/testing_profile.h:158: // TestURLRequestContextGetter class,
many tests would find themseleves
typo: themseleves

http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
File content/browser/browser_context.cc (right):

http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
content/browser/browser_context.cc:62: context->IsOffTheRecord(),
context->GetPath(),
http://crbug.com/89628 {sob}

and four other times below. I know it's just moving code around but it still
makes me sad.

http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
File content/public/common/content_constants.cc (right):

http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
content/public/common/content_constants.cc:6: namespace content {
blank line before

[jam, 2012-02-17 16:29:25]

http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.h (right):

http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.h:184: // content::BrowserContext implementation
------------------------------------
On 2012/02/17 16:25:09, Avi wrote:
> This comment marks the end of the implementation; remove it too.

Done.

http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
File chrome/test/base/testing_profile.h (right):

http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
chrome/test/base/testing_profile.h:158: // TestURLRequestContextGetter class,
many tests would find themseleves
On 2012/02/17 16:25:09, Avi wrote:
> typo: themseleves

Done.

http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
File content/browser/browser_context.cc (right):

http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
content/browser/browser_context.cc:62: context->IsOffTheRecord(),
context->GetPath(),
On 2012/02/17 16:25:09, Avi wrote:
> http://crbug.com/89628 {sob}
> 
> and four other times below. I know it's just moving code around but it still
> makes me sad.

agree, it bothered me every time i moved this code.

I hope that we can at least make it more general, i.e. maybe just call it
in_memory only or something

http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
File content/public/common/content_constants.cc (right):

http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
content/public/common/content_constants.cc:6: namespace content {
On 2012/02/17 16:25:09, Avi wrote:
> blank line before

Done.

[Miranda Callahan, 2012-02-17 16:39:36]

On 2012/02/17 16:29:25, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
> File chrome/browser/profiles/profile.h (right):
> 
>
http://codereview.chromium.org/9419033/diff/5157/chrome/browser/profiles/prof...
> chrome/browser/profiles/profile.h:184: // content::BrowserContext
implementation
> ------------------------------------
> On 2012/02/17 16:25:09, Avi wrote:
> > This comment marks the end of the implementation; remove it too.
> 
> Done.
> 
>
http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
> File chrome/test/base/testing_profile.h (right):
> 
>
http://codereview.chromium.org/9419033/diff/5157/chrome/test/base/testing_pro...
> chrome/test/base/testing_profile.h:158: // TestURLRequestContextGetter class,
> many tests would find themseleves
> On 2012/02/17 16:25:09, Avi wrote:
> > typo: themseleves
> 
> Done.
> 
>
http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
> File content/browser/browser_context.cc (right):
> 
>
http://codereview.chromium.org/9419033/diff/5157/content/browser/browser_cont...
> content/browser/browser_context.cc:62: context->IsOffTheRecord(),
> context->GetPath(),
> On 2012/02/17 16:25:09, Avi wrote:
> > http://crbug.com/89628 {sob}
> > 
> > and four other times below. I know it's just moving code around but it still
> > makes me sad.
> 
> agree, it bothered me every time i moved this code.
> 
> I hope that we can at least make it more general, i.e. maybe just call it
> in_memory only or something
> 
>
http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
> File content/public/common/content_constants.cc (right):
> 
>
http://codereview.chromium.org/9419033/diff/5157/content/public/common/conten...
> content/public/common/content_constants.cc:6: namespace content {
> On 2012/02/17 16:25:09, Avi wrote:
> > blank line before
> 
> Done.

profile changes LGTM.

[jam, 2012-02-20 17:33:35]

Avi: I'm relanding this with fixes for heapcheck/valgrind. you can see the
changes between patchset 6 and 7, which are similar to how other objects are
leak-avoided in webkit layer.

[jam, 2012-02-20 17:34:55]

On 2012/02/20 17:33:35, John Abd-El-Malek wrote:
> Avi: I'm relanding this with fixes for heapcheck/valgrind. you can see the
> changes between patchset 6 and 7, which are similar to how other objects are
> leak-avoided in webkit layer.

btw the heapcheck trybot is showing a few leaks. locally it doesn't after a few
runs. so i'll see if they show up on the buildbot, and if so i'll add
suppressions

[Avi (use Gerrit), 2012-02-20 18:26:40]

slgtm