webkit/appcache/appcache_storage_impl.cc - Issue 9419033: Move creation of BrowserContext objects that live in content to content, instead of depending on th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_storage_impl.cc

Issue 9419033: Move creation of BrowserContext objects that live in content to content, instead of depending on th… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Fix memory leaks in tests Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/appcache/appcache_storage_impl.cc

===================================================================

--- webkit/appcache/appcache_storage_impl.cc (revision 122721)

+++ webkit/appcache/appcache_storage_impl.cc (working copy)

@@ -1221,13 +1221,14 @@

scheduled_database_tasks_.end(),

std::mem_fun(&DatabaseTask::CancelCompletion));

- if (database_) {

- db_thread_->PostTask(

- FROM_HERE,

- base::Bind(&CleanUpOnDatabaseThread, database_,

- make_scoped_refptr(service_->special_storage_policy()),

- service()->clear_local_state_on_exit(),

- service()->save_session_state()));

+ if (database_ &&

+ !db_thread_->PostTask(

+ FROM_HERE,

+ base::Bind(&CleanUpOnDatabaseThread, database_,

+ make_scoped_refptr(service_->special_storage_policy()),

+ service()->clear_local_state_on_exit(),

+ service()->save_session_state()))) {

+ delete database_;

}

« no previous file with comments | « content/test/test_browser_thread.cc ('k') | webkit/fileapi/file_system_context.cc » ('j') | no next file with comments »