Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 9418017: make: don't use .target in paths or printouts (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 9 months ago
Reviewers:
Nico, piman
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: don't use .target in paths or printouts Instead, .target is considered the default, unnamed configuration, while .host remains printed and pathed as before. Committed: https://code.google.com/p/gyp/source/detail?r=1209

Patch Set 1 #

Patch Set 2 : simpler #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -70 lines) Patch
M pylib/gyp/generator/make.py View 1 15 chunks +76 lines, -64 lines 2 comments Download
M test/lib/TestGyp.py View 3 chunks +6 lines, -5 lines 0 comments Download
M test/make/gyptest-dependencies.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
The tests seem to pass. And my build output is pretty: $ make base_unittests CXX ...
8 years, 10 months ago (2012-02-16 20:17:02 UTC) #1
Nico
LGTM as far as I can tell. (I know of one script that will need ...
8 years, 10 months ago (2012-02-16 20:30:08 UTC) #2
Evan Martin
On 2012/02/16 20:30:08, Nico wrote: > Curious: Is this on the path for a nicer ...
8 years, 10 months ago (2012-02-16 20:35:19 UTC) #3
piman
8 years, 9 months ago (2012-03-06 01:54:03 UTC) #4
Belated LGTM

Powered by Google App Engine
This is Rietveld 408576698