Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: test/lib/TestGyp.py

Issue 9418017: make: don't use .target in paths or printouts (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: simpler Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/lib/TestGyp.py
diff --git a/test/lib/TestGyp.py b/test/lib/TestGyp.py
index 7fbb56bfac8623b4960c9a99b0d048870075ecac..c32c959a2da098e71c0f332ab5b2d679412c02de 100644
--- a/test/lib/TestGyp.py
+++ b/test/lib/TestGyp.py
@@ -371,8 +371,9 @@ class TestGypMake(TestGypBase):
"""
configuration = self.configuration_dirname()
libdir = os.path.join('out', configuration, 'lib')
- # TODO(piman): when everything is cross-compile safe, remove lib.target
- os.environ['LD_LIBRARY_PATH'] = libdir + '.host:' + libdir + '.target'
+ # TODO(piman): when everything is cross-compile safe, remove
+ # the trailing 'libdir' that pulls in target-compiled libs as well.
+ os.environ['LD_LIBRARY_PATH'] = libdir + '.host:' + libdir
# Enclosing the name in a list avoids prepending the original dir.
program = [self.built_file_path(name, type=self.EXECUTABLE, **kw)]
return self.run(program=program, *args, **kw)
@@ -391,7 +392,7 @@ class TestGypMake(TestGypBase):
prefixes and suffixes to a platform-independent library base name.
A subdir= keyword argument specifies a library subdirectory within
- the default 'obj.target'.
+ the default 'obj'.
"""
result = []
chdir = kw.get('chdir')
@@ -400,9 +401,9 @@ class TestGypMake(TestGypBase):
configuration = self.configuration_dirname()
result.extend(['out', configuration])
if type == self.STATIC_LIB and sys.platform != 'darwin':
- result.append('obj.target')
+ result.append('obj')
elif type == self.SHARED_LIB and sys.platform != 'darwin':
- result.append('lib.target')
+ result.append('lib')
subdir = kw.get('subdir')
if subdir:
result.append(subdir)

Powered by Google App Engine
This is Rietveld 408576698