Issue 9418005: Ensure using byte registers for byte instructions on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9418005: Ensure using byte registers for byte instructions on ia32 and x64. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure using byte registers for byte instructions on ia32 and x64. BUG=v8:1945 TEST=regress-1945.js Committed: https://code.google.com/p/v8/source/detail?r=10719

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : . #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -25 lines)			Patch
M	src/ia32/assembler-ia32.cc	View	1 2	8 chunks	+10 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/x64/assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 2	9 chunks	+9 lines, -9 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
A	test/mjsunit/regress/regress-1945.js	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-16 12:46:01 UTC) #2

LGTM with date nits.

http://codereview.chromium.org/9418005/diff/7/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):

http://codereview.chromium.org/9418005/diff/7/src/ia32/assembler-ia32.cc#newc...
src/ia32/assembler-ia32.cc:35: // Copyright 2011 the V8 project authors. All
rights reserved.
2012

http://codereview.chromium.org/9418005/diff/7/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/9418005/diff/7/src/x64/assembler-x64.cc#newcode1
src/x64/assembler-x64.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
2012

http://codereview.chromium.org/9418005/diff/7/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/9418005/diff/7/src/x64/assembler-x64.h#newcode33
src/x64/assembler-x64.h:33: // Copyright 2011 the V8 project authors. All rights
reserved.
2012

Expand Messages | Collapse Messages