runtime/vm/code_generator_ia32.cc - Issue 9415002: Fix crash in assembler when tracing function (must be zone handle). Fixes bug 1709.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 9415002: Fix crash in assembler when tracing function (must be zone handle). Fixes bug 1709. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_ia32.cc

===================================================================

--- runtime/vm/code_generator_ia32.cc (revision 4300)

+++ runtime/vm/code_generator_ia32.cc (working copy)

@@ -703,7 +703,7 @@

if (FLAG_trace_functions) {

__ pushl(EAX); // Preserve result.

- __ PushObject(function);

+ __ PushObject(Function::ZoneHandle(function.raw()));

GenerateCallRuntime(AstNode::kNoId,

kTraceFunctionExitRuntimeEntry);

« no previous file with comments | « no previous file | no next file » | no next file with comments »