Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: runtime/vm/code_generator_ia32.cc

Issue 9415002: Fix crash in assembler when tracing function (must be zone handle). Fixes bug 1709. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/code_generator.h" 8 #include "vm/code_generator.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 // EBP + 4 : points to return address. 696 // EBP + 4 : points to return address.
697 // EBP + 8 : address of last argument (arg n-1). 697 // EBP + 8 : address of last argument (arg n-1).
698 // ESP + 8 + 4*(n-1) : address of first argument (arg 0). 698 // ESP + 8 + 4*(n-1) : address of first argument (arg 0).
699 // ECX : ic-data array. 699 // ECX : ic-data array.
700 // EDX : arguments descriptor array. 700 // EDX : arguments descriptor array.
701 __ call(&StubCode::CallNoSuchMethodFunctionLabel()); 701 __ call(&StubCode::CallNoSuchMethodFunctionLabel());
702 } 702 }
703 703
704 if (FLAG_trace_functions) { 704 if (FLAG_trace_functions) {
705 __ pushl(EAX); // Preserve result. 705 __ pushl(EAX); // Preserve result.
706 __ PushObject(function); 706 __ PushObject(Function::ZoneHandle(function.raw()));
707 GenerateCallRuntime(AstNode::kNoId, 707 GenerateCallRuntime(AstNode::kNoId,
708 0, 708 0,
709 kTraceFunctionExitRuntimeEntry); 709 kTraceFunctionExitRuntimeEntry);
710 __ popl(EAX); // Remove argument. 710 __ popl(EAX); // Remove argument.
711 __ popl(EAX); // Restore result. 711 __ popl(EAX); // Restore result.
712 } 712 }
713 __ LeaveFrame(); 713 __ LeaveFrame();
714 __ ret(); 714 __ ret();
715 715
716 __ Bind(&all_arguments_processed); 716 __ Bind(&all_arguments_processed);
(...skipping 2091 matching lines...) Expand 10 before | Expand all | Expand 10 after
2808 const Error& error = Error::Handle( 2808 const Error& error = Error::Handle(
2809 Parser::FormatError(script, token_index, "Error", format, args)); 2809 Parser::FormatError(script, token_index, "Error", format, args));
2810 va_end(args); 2810 va_end(args);
2811 Isolate::Current()->long_jump_base()->Jump(1, error); 2811 Isolate::Current()->long_jump_base()->Jump(1, error);
2812 UNREACHABLE(); 2812 UNREACHABLE();
2813 } 2813 }
2814 2814
2815 } // namespace dart 2815 } // namespace dart
2816 2816
2817 #endif // defined TARGET_ARCH_IA32 2817 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698