Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1753)

Unified Diff: chrome/browser/extensions/settings/settings_sync_unittest.cc

Issue 9414020: [Sync] Switch Extension Settings DTC to use ProfilesyncComponentsFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove RunWithSyncableService and clean up Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_sync_unittest.cc
diff --git a/chrome/browser/extensions/settings/settings_sync_unittest.cc b/chrome/browser/extensions/settings/settings_sync_unittest.cc
index 0b489d262012664f7254ea0b95e69e63d646fcd3..9ec56cbb2490cfefba31ef1d9fe5bd0c7ce4d01a 100644
--- a/chrome/browser/extensions/settings/settings_sync_unittest.cc
+++ b/chrome/browser/extensions/settings/settings_sync_unittest.cc
@@ -168,8 +168,10 @@ class TestingSettingsStorageFactory : public SettingsStorageFactory {
std::map<std::string, TestingSettingsStorage*> created_;
};
-void AssignSettingsService(SyncableService** dst, SyncableService* src) {
- *dst = src;
+void AssignSettingsService(SyncableService** dst,
+ const SettingsFrontend* frontend,
+ syncable::ModelType type) {
+ *dst = frontend->GetBackendForSync(type);
}
} // namespace
@@ -206,8 +208,11 @@ class ExtensionSettingsSyncTest : public testing::Test {
// Gets the SyncableService for the given sync type.
SyncableService* GetSyncableService(syncable::ModelType model_type) {
SyncableService* settings_service = NULL;
- frontend_->RunWithSyncableService(
- model_type, base::Bind(&AssignSettingsService, &settings_service));
+ BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+ base::Bind(&AssignSettingsService,
+ &settings_service,
+ frontend_.get(),
+ model_type));
not at google - send to devlin 2012/02/16 22:58:44 Same comment here as in apitest.cc. Hopefully no n
Nicolas Zea 2012/02/23 00:27:58 Done.
not at google - send to devlin 2012/02/23 02:15:38 Same response as before.
Nicolas Zea 2012/02/24 21:38:04 See other comment.
MessageLoop::current()->RunAllPending();
return settings_service;
}

Powered by Google App Engine
This is Rietveld 408576698