[Sync] Switch Extension Settings DTC to use ProfilesyncComponentsFactory

chrome/browser/extensions/settings/settings_sync_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 150 matching lines @@
 
  private:
   // SettingsStorageFactory is refcounted.
   virtual ~TestingSettingsStorageFactory() {}
 
   // None of these storage areas are owned by this factory, so care must be
   // taken when calling GetExisting.
   std::map<std::string, TestingSettingsStorage*> created_;
 };
 
-void AssignSettingsService(SyncableService** dst, SyncableService* src) {
-  *dst = src;
+void AssignSettingsService(SyncableService** dst,
+                           const SettingsFrontend* frontend,
+                           syncable::ModelType type) {
+  *dst = frontend->GetBackendForSync(type);
 }
 
 }  // namespace
 
 class ExtensionSettingsSyncTest : public testing::Test {
  public:
   ExtensionSettingsSyncTest()
       : ui_thread_(BrowserThread::UI, MessageLoop::current()),
         file_thread_(BrowserThread::FILE, MessageLoop::current()),
         storage_factory_(new ScopedSettingsStorageFactory()) {}
@@ skipping 16 matching lines @@
   // its storage area.
   SettingsStorage* AddExtensionAndGetStorage(
       const std::string& id, Extension::Type type) {
     profile_->GetMockExtensionService()->AddExtensionWithId(id, type);
     return GetStorage(id, frontend_.get());
   }
 
   // Gets the SyncableService for the given sync type.
   SyncableService* GetSyncableService(syncable::ModelType model_type) {
     SyncableService* settings_service = NULL;
-    frontend_->RunWithSyncableService(
-        model_type, base::Bind(&AssignSettingsService, &settings_service));
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+        base::Bind(&AssignSettingsService,
+                   &settings_service,
+                   frontend_.get(),
+                   model_type));

[not at google - send to devlin, 2012/02/16 22:58:44]

Same comment here as in apitest.cc. Hopefully no need for PostTask anymore?

[Nicolas Zea, 2012/02/23 00:27:58]

Done.

[not at google - send to devlin, 2012/02/23 02:15:38]

Same response as before.

[Nicolas Zea, 2012/02/24 21:38:04]

See other comment.

     MessageLoop::current()->RunAllPending();
     return settings_service;
   }
 
   // Gets all the sync data from the SyncableService for a sync type as a map
   // from extension id to its sync data.
   std::map<std::string, SettingSyncDataList> GetAllSyncData(
       syncable::ModelType model_type) {
     SyncDataList as_list =
         GetSyncableService(model_type)->GetAllSyncData(model_type);
@@ skipping 1062 matching lines @@
     DictionaryValue expected;
     expected.Set("large_value", large_value.DeepCopy());
     EXPECT_PRED_FORMAT2(SettingsEq, expected, storage1->Get());
     EXPECT_PRED_FORMAT2(SettingsEq, expected, storage2->Get());
   }
 
   GetSyncableService(model_type)->StopSyncing(model_type);
 }
 
 }  // namespace extensions