Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/resources/help/help.js

Issue 9413028: Help: Show the platform version and firmware on CrOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/help/help.js
diff --git a/chrome/browser/resources/help/help.js b/chrome/browser/resources/help/help.js
index e703a23fdd45d53481837c95bc04d39a17c27ab9..08c80083014aa54f4629d2d02bc558fd51c021c5 100644
--- a/chrome/browser/resources/help/help.js
+++ b/chrome/browser/resources/help/help.js
@@ -40,7 +40,7 @@ cr.define('help_page', function() {
}
// Attempt to update.
- chrome.send('checkForUpdate');
+ chrome.send('onPageLoaded');
},
/**
@@ -79,7 +79,27 @@ cr.define('help_page', function() {
*/
setProgress_: function(progress) {
$('update-percentage').innerHTML = progress + "%";
- }
+ },
+
+ /**
+ * @private
+ */
+ setOSVersion_: function(version) {
+ if (!cr.isChromeOS)
+ console.error('OS version unsupported on non-CrOS');
+
+ $('os-version').textContent = version;
+ },
+
+ /**
+ * @private
+ */
+ setOSFirmware_: function(firmware) {
+ if (!cr.isChromeOS)
+ console.error('OS firmware unsupported on non-CrOS');
+
+ $('firmware').textContent = firmware;
+ },
};
HelpPage.setUpdateStatus = function(status) {
@@ -90,6 +110,15 @@ cr.define('help_page', function() {
HelpPage.getInstance().setProgress_(progress);
};
+ HelpPage.setOSVersion = function(version) {
+ console.log('setOSVersion: ' + version);
csilv 2012/02/17 01:21:49 remove this line
James Hawkins 2012/02/17 01:29:27 Done.
+ HelpPage.getInstance().setOSVersion_(version);
+ };
+
+ HelpPage.setOSFirmware = function(firmware) {
+ HelpPage.getInstance().setOSFirmware_(firmware);
+ };
+
// Export
return {
HelpPage: HelpPage

Powered by Google App Engine
This is Rietveld 408576698