Help: Show the platform version and firmware on CrOS.

Help: Show the platform version and firmware on CrOS.

BUG=113546
TEST=none
R=csilv


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122461

[csilv, 2012-02-17 01:21:49]

lgtm w/ nit fixes.

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
File chrome/browser/resources/help/help.css (right):

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
chrome/browser/resources/help/help.css:28: font-size: 90%;
not required, but we should start thinking in em's for font-sizes.

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
File chrome/browser/resources/help/help.js (right):

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
chrome/browser/resources/help/help.js:114: console.log('setOSVersion: ' +
version);
remove this line

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:169: version = std::string("130.0.0
(Official Build) dev-channel-stumpy");
You can get rid of this placeholder string.

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:178: firmware =
std::string("Google_stumpy 2.59.0");
this one too

[James Hawkins, 2012-02-17 01:29:27]

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
File chrome/browser/resources/help/help.js (right):

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/resource...
chrome/browser/resources/help/help.js:114: console.log('setOSVersion: ' +
version);
On 2012/02/17 01:21:49, csilv wrote:
> remove this line

Done.

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:169: version = std::string("130.0.0
(Official Build) dev-channel-stumpy");
On 2012/02/17 01:21:49, csilv wrote:
> You can get rid of this placeholder string.

Done.

https://chromiumcodereview.appspot.com/9413028/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:178: firmware =
std::string("Google_stumpy 2.59.0");
On 2012/02/17 01:21:49, csilv wrote:
> this one too

Done.

[commit-bot: I haz the power, 2012-02-17 04:19:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/9413028/4002

[commit-bot: I haz the power, 2012-02-17 05:42:27]

Change committed as 122461