Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: icu.gyp

Issue 9407013: Move -Wno-switch in ICU to the target that actually needs it :-/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
===================================================================
--- icu.gyp (revision 122096)
+++ icu.gyp (working copy)
@@ -333,12 +333,6 @@
# the header should use U_NAMESPACE_BEGIN instead.
# http://bugs.icu-project.org/trac/ticket/9054
'-Wno-header-hygiene',
- # uresdata.c has switch(RES_GET_TYPE(x)) code. The
- # RES_GET_TYPE macro returns an UResType enum, but some switch
- # statement contains case values that aren't part of that
- # enum (e.g. URES_TABLE32 which is in UResInternalType). This
- # is on purpose.
- '-Wno-switch',
],
},
'cflags': [
@@ -346,7 +340,6 @@
'-Wno-logical-op-parentheses',
'-Wno-tautological-compare',
'-Wno-header-hygiene',
- '-Wno-switch',
],
}],
],
@@ -599,12 +592,19 @@
'-Wno-logical-op-parentheses',
# ICU has some `unsigned < 0` checks.
'-Wno-tautological-compare',
+ # uresdata.c has switch(RES_GET_TYPE(x)) code. The
+ # RES_GET_TYPE macro returns an UResType enum, but some switch
+ # statement contains case values that aren't part of that
+ # enum (e.g. URES_TABLE32 which is in UResInternalType). This
+ # is on purpose.
+ '-Wno-switch',
],
},
'cflags': [
'-Wno-deprecated-declarations',
'-Wno-logical-op-parentheses',
'-Wno-tautological-compare',
+ '-Wno-switch',
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698