Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: icu.gyp

Issue 9407013: Move -Wno-switch in ICU to the target that actually needs it :-/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_icu%': 0, 7 'use_system_icu%': 0,
8 'icu_use_data_file_flag%': 0, 8 'icu_use_data_file_flag%': 0,
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 # ICU uses its own deprecated functions. 326 # ICU uses its own deprecated functions.
327 '-Wno-deprecated-declarations', 327 '-Wno-deprecated-declarations',
328 # ICU prefers `a && b || c` over `(a && b) || c`. 328 # ICU prefers `a && b || c` over `(a && b) || c`.
329 '-Wno-logical-op-parentheses', 329 '-Wno-logical-op-parentheses',
330 # ICU has some `unsigned < 0` checks. 330 # ICU has some `unsigned < 0` checks.
331 '-Wno-tautological-compare', 331 '-Wno-tautological-compare',
332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug, 332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
333 # the header should use U_NAMESPACE_BEGIN instead. 333 # the header should use U_NAMESPACE_BEGIN instead.
334 # http://bugs.icu-project.org/trac/ticket/9054 334 # http://bugs.icu-project.org/trac/ticket/9054
335 '-Wno-header-hygiene', 335 '-Wno-header-hygiene',
336 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
337 # RES_GET_TYPE macro returns an UResType enum, but some switch
338 # statement contains case values that aren't part of that
339 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
340 # is on purpose.
341 '-Wno-switch',
342 ], 336 ],
343 }, 337 },
344 'cflags': [ 338 'cflags': [
345 '-Wno-deprecated-declarations', 339 '-Wno-deprecated-declarations',
346 '-Wno-logical-op-parentheses', 340 '-Wno-logical-op-parentheses',
347 '-Wno-tautological-compare', 341 '-Wno-tautological-compare',
348 '-Wno-header-hygiene', 342 '-Wno-header-hygiene',
349 '-Wno-switch',
350 ], 343 ],
351 }], 344 }],
352 ], 345 ],
353 }, 346 },
354 { 347 {
355 'target_name': 'icuuc', 348 'target_name': 'icuuc',
356 'type': '<(component)', 349 'type': '<(component)',
357 'sources': [ 350 'sources': [
358 'source/common/bmpset.cpp', 351 'source/common/bmpset.cpp',
359 'source/common/brkeng.cpp', 352 'source/common/brkeng.cpp',
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 }], 585 }],
593 ['clang==1', { 586 ['clang==1', {
594 'xcode_settings': { 587 'xcode_settings': {
595 'WARNING_CFLAGS': [ 588 'WARNING_CFLAGS': [
596 # ICU uses its own deprecated functions. 589 # ICU uses its own deprecated functions.
597 '-Wno-deprecated-declarations', 590 '-Wno-deprecated-declarations',
598 # ICU prefers `a && b || c` over `(a && b) || c`. 591 # ICU prefers `a && b || c` over `(a && b) || c`.
599 '-Wno-logical-op-parentheses', 592 '-Wno-logical-op-parentheses',
600 # ICU has some `unsigned < 0` checks. 593 # ICU has some `unsigned < 0` checks.
601 '-Wno-tautological-compare', 594 '-Wno-tautological-compare',
595 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
596 # RES_GET_TYPE macro returns an UResType enum, but some switch
597 # statement contains case values that aren't part of that
598 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
599 # is on purpose.
600 '-Wno-switch',
602 ], 601 ],
603 }, 602 },
604 'cflags': [ 603 'cflags': [
605 '-Wno-deprecated-declarations', 604 '-Wno-deprecated-declarations',
606 '-Wno-logical-op-parentheses', 605 '-Wno-logical-op-parentheses',
607 '-Wno-tautological-compare', 606 '-Wno-tautological-compare',
607 '-Wno-switch',
608 ], 608 ],
609 }], 609 }],
610 ], 610 ],
611 }, 611 },
612 ], 612 ],
613 }, { # use_system_icu != 0 613 }, { # use_system_icu != 0
614 'targets': [ 614 'targets': [
615 { 615 {
616 'target_name': 'system_icu', 616 'target_name': 'system_icu',
617 'type': 'none', 617 'type': 'none',
(...skipping 26 matching lines...) Expand all
644 { 644 {
645 'target_name': 'icuuc', 645 'target_name': 'icuuc',
646 'type': 'none', 646 'type': 'none',
647 'dependencies': ['system_icu'], 647 'dependencies': ['system_icu'],
648 'export_dependent_settings': ['system_icu'], 648 'export_dependent_settings': ['system_icu'],
649 }, 649 },
650 ], 650 ],
651 }], 651 }],
652 ], 652 ],
653 } 653 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698