runtime/vm/gc_marker.cc - Issue 9398014: Ignore deleted handles when processing weak roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 9398014: Ignore deleted handles when processing weak roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: final revision Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/gc_marker.cc

diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc

index 2c8c9f2fb73a2b3ca036b0790808b1109efa94f0..62f1f3a0267c4dbc75ab3c73d6966680556e7707 100644

--- a/runtime/vm/gc_marker.cc

+++ b/runtime/vm/gc_marker.cc

@@ -197,7 +197,7 @@ class MarkingWeakVisitor : public HandleVisitor {

WeakPersistentHandle* handle =

reinterpret_cast<WeakPersistentHandle*>(addr);

RawObject* raw_obj = handle->raw();

- ASSERT(raw_obj->IsHeapObject());

+ if (!raw_obj->IsHeapObject()) return;

if (!raw_obj->IsMarked() && raw_obj->IsOldObject()) {

WeakPersistentHandle::Finalize(handle);

}

« no previous file with comments | « runtime/vm/dart_api_state.h ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »