runtime/vm/dart_api_state.h - Issue 9398014: Ignore deleted handles when processing weak roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_state.h

Issue 9398014: Ignore deleted handles when processing weak roots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: final revision Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_state.h

diff --git a/runtime/vm/dart_api_state.h b/runtime/vm/dart_api_state.h

index fc80adc4fc3752389b16996199169dc1ab7fd263..a1f276ca8c79bf734b0dba9a215355096f785c2c 100644

--- a/runtime/vm/dart_api_state.h

+++ b/runtime/vm/dart_api_state.h

@@ -135,8 +135,8 @@ class WeakPersistentHandle {

}

static void Finalize(WeakPersistentHandle* handle) {

- if (handle->callback() != NULL) {

- Dart_WeakPersistentHandleFinalizer callback = handle->callback();

+ Dart_WeakPersistentHandleFinalizer callback = handle->callback();

+ if (callback != NULL) {

void* peer = handle->peer();

handle->Clear();

(*callback)(reinterpret_cast<Dart_Handle>(handle), peer);

« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/gc_marker.cc » ('j') | no next file with comments »