Custom frame UI for platform apps on Windows.

Custom frame UI for platform apps on Windows.

Initially committed as r121408, this patch contains fixes for XP, and for aura on CrOS and Windows.

Initial code review: http://codereview.chromium.org/9254046/

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122242

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122934

[jeremya, 2012-02-13 23:52:30]

https://chromiumcodereview.appspot.com/9391024/diff/1/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/shell_window_views.cc (right):

https://chromiumcodereview.appspot.com/9391024/diff/1/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/shell_window_views.cc:10: #include
"ui/base/hit_test.h"
Added this line.

https://chromiumcodereview.appspot.com/9391024/diff/1/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/shell_window_views.cc:153: #if
defined(OS_WIN) && !defined(USE_AURA)
Added && !defined(USE_AURA)

[Ben Goodger (Google), 2012-02-15 20:40:10]

lgtm

[commit-bot: I haz the power, 2012-02-15 20:42:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/1

[commit-bot: I haz the power, 2012-02-15 21:36:29]

Try job failure for 9391024-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-16 01:38:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/12002

[commit-bot: I haz the power, 2012-02-16 02:48:21]

Try job failure for 9391024-12002 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-16 03:01:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/12002

[commit-bot: I haz the power, 2012-02-16 04:27:34]

Change committed as 122242

[commit-bot: I haz the power, 2012-02-21 06:15:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/18006

[commit-bot: I haz the power, 2012-02-21 06:15:20]

Presubmit check for 9391024-18006 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/public/browser/render_widget_host_view.h

Presubmit checks took 1.6s to calculate.

[jeremya, 2012-02-21 06:16:53]

Hi jam- I need this API for some platform apps stuff. I'm not sure if this is
the best place to add it: if not, please advise :)

Thanks,
Jeremy

[jeremya, 2012-02-21 06:22:17]

https://chromiumcodereview.appspot.com/9391024/diff/20016/content/public/brow...
File content/public/browser/render_widget_host_view.h (right):

https://chromiumcodereview.appspot.com/9391024/diff/20016/content/public/brow...
content/public/browser/render_widget_host_view.h:143: virtual void
SetTransparentRegion(SkRegion* region) {}
This is the API I was asking about, jam :)

[jam, 2012-02-21 18:36:20]

if ben is fine with it on the interface, lgtm. it doesnt break any
content/chrome abstraction layers.

[commit-bot: I haz the power, 2012-02-21 22:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/20016

[commit-bot: I haz the power, 2012-02-21 22:51:35]

Can't process patch for file content/public/browser/render_widget_host_view.h.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2012-02-21 23:04:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/9391024/28001

[commit-bot: I haz the power, 2012-02-22 00:54:55]

Change committed as 122934