Issue 9387027: Revert 121840 - Make scoped dc objects smarter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9387027: Revert 121840 - Make scoped dc objects smarter (Closed)

Created:
8 years, 10 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 10 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 121840 - Make scoped dc objects smarter So we don't destroy the dc with gdi objects selected. Also remove implicit conversion to HDC. BUG=110113, 113683 TEST=chrome runs, base unittests green. Review URL: https://chromiumcodereview.appspot.com/9212020 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121843

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -327 lines)			Patch
M	base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/win/scoped_hdc.h	View	2 chunks	+45 lines, -67 lines	0 comments	Download
D	base/win/scoped_hdc.cc	View	1 chunk	+0 lines, -116 lines	0 comments	Download
D	base/win/scoped_hdc_unittest.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	chrome/browser/aeropeek_manager.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_win.cc	View	1 chunk	+19 lines, -12 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	6 chunks	+16 lines, -15 lines	0 comments	Download
M	printing/emf_win_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/host/disconnect_window_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/native_theme_win.cc	View	3 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

remoting lgtm.

Expand Messages | Collapse Messages