Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 9381019: Revert 121423 - Don't strip punctuation inside quotes in history search queries. (Closed)

Created:
8 years, 10 months ago by brettw
Modified:
8 years, 10 months ago
Reviewers:
Patrick Dubroy
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 121423 - Don't strip punctuation inside quotes in history search queries. (accidentally committed due to bad owners file). Currently, the query parser strips all punctuation from history search queries, even inside quotes. A query like ["chromium.org"] will be passed to SQLite as ["chromium org"], meaning that pages on chromium.org will not be matched unless they contain the literal string "chromium org" somewhere. BUG=100545 TEST=Do a search on chrome://history for a domain that you have previously visited, e.g. "chromium.org", and ensure that history entries matching this domain are found. Review URL: http://codereview.chromium.org/9316129 TBR=dubroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -187 lines) Patch
M chrome/browser/history/query_parser.cc View 9 chunks +22 lines, -54 lines 0 comments Download
M chrome/browser/history/query_parser_unittest.cc View 4 chunks +1 line, -26 lines 0 comments Download
M chrome/browser/history/text_database_manager_unittest.cc View 23 chunks +40 lines, -107 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
8 years, 10 months ago (2012-02-10 21:13:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698