Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/history/query_parser_unittest.cc

Issue 9381019: Revert 121423 - Don't strip punctuation inside quotes in history search queries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/memory/scoped_vector.h" 6 #include "base/memory/scoped_vector.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/history/query_parser.h" 8 #include "chrome/browser/history/query_parser.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 class QueryParserTest : public testing::Test { 11 class QueryParserTest : public testing::Test {
(...skipping 28 matching lines...) Expand all
40 EXPECT_EQ("f b", QueryToString(" f b")); 40 EXPECT_EQ("f b", QueryToString(" f b"));
41 // KA JANG 41 // KA JANG
42 EXPECT_EQ(WideToUTF8(L"\xAC00 \xC7A5"), 42 EXPECT_EQ(WideToUTF8(L"\xAC00 \xC7A5"),
43 QueryToString(WideToUTF8(L" \xAC00 \xC7A5"))); 43 QueryToString(WideToUTF8(L" \xAC00 \xC7A5")));
44 EXPECT_EQ("foo* bar*", QueryToString(" foo bar ")); 44 EXPECT_EQ("foo* bar*", QueryToString(" foo bar "));
45 // KA-JANG BICH-GO 45 // KA-JANG BICH-GO
46 EXPECT_EQ(WideToUTF8(L"\xAC00\xC7A5* \xBE5B\xACE0*"), 46 EXPECT_EQ(WideToUTF8(L"\xAC00\xC7A5* \xBE5B\xACE0*"),
47 QueryToString(WideToUTF8(L"\xAC00\xC7A5 \xBE5B\xACE0"))); 47 QueryToString(WideToUTF8(L"\xAC00\xC7A5 \xBE5B\xACE0")));
48 } 48 }
49 49
50 TEST_F(QueryParserTest, Numbers) {
51 EXPECT_EQ("66", QueryToString("66"));
52 EXPECT_EQ("wayne99gretzky*", QueryToString("wayne99gretzky"));
53 }
54
55 // Quoted substring parsing. 50 // Quoted substring parsing.
56 TEST_F(QueryParserTest, Quoted) { 51 TEST_F(QueryParserTest, Quoted) {
57 // ASCII quotes 52 // ASCII quotes
58 EXPECT_EQ("\"Quoted\"", QueryToString("\"Quoted\"")); 53 EXPECT_EQ("\"Quoted\"", QueryToString("\"Quoted\""));
59 // Missing end quotes 54 // Missing end quotes
60 EXPECT_EQ("\"miss end\"", QueryToString("\"miss end")); 55 EXPECT_EQ("\"miss end\"", QueryToString("\"miss end"));
61 // Missing begin quotes 56 // Missing begin quotes
62 EXPECT_EQ("miss* beg*", QueryToString("miss beg\"")); 57 EXPECT_EQ("miss* beg*", QueryToString("miss beg\""));
63 // Weird formatting 58 // Weird formatting
64 EXPECT_EQ("\"Many\" \"quotes\"", QueryToString("\"Many \"\"quotes")); 59 EXPECT_EQ("\"Many\" \"quotes\"", QueryToString("\"Many \"\"quotes"));
65 EXPECT_EQ("\"ab\" cd \"ef\"", QueryToString("\"ab\" cd \"ef\""));
66 EXPECT_EQ("tra* \"la\" la", QueryToString("tra \"la\" la"));
67 } 60 }
68 61
69 // Apostrophes within words should be preserved, but otherwise stripped. 62 // Apostrophes within words should be preserved, but otherwise stripped.
70 TEST_F(QueryParserTest, Apostrophes) { 63 TEST_F(QueryParserTest, Apostrophes) {
71 EXPECT_EQ("foo* bar's*", QueryToString("foo bar's")); 64 EXPECT_EQ("foo* bar's*", QueryToString("foo bar's"));
72 EXPECT_EQ("l'foo*", QueryToString("l'foo")); 65 EXPECT_EQ("l'foo*", QueryToString("l'foo"));
73 EXPECT_EQ("foo*", QueryToString("'foo")); 66 EXPECT_EQ("foo*", QueryToString("'foo"));
74 } 67 }
75 68
76 // Special characters. 69 // Special characters.
77 TEST_F(QueryParserTest, SpecialChars) { 70 TEST_F(QueryParserTest, SpecialChars) {
78 EXPECT_EQ("foo* the* bar*", QueryToString("!#:/*foo#$*;'* the!#:/*bar")); 71 EXPECT_EQ("foo* the* bar*", QueryToString("!#:/*foo#$*;'* the!#:/*bar"));
79
80 // Domain-name-like strings should be left intact.
81 EXPECT_EQ("chromium.org*", QueryToString("chromium.org"));
82 EXPECT_EQ("a.b.c*", QueryToString("a.b.c"));
83
84 // More complex queries will get broken up, but that's ok.
85 EXPECT_EQ("hhof.com* cup* a b c d 20e*",
86 QueryToString("hhof.com/cup?a=b&c=d%20e"));
87
88 // Special chars inside quotes should be preserved.
89 EXPECT_EQ("\"$FOO\" bar*", QueryToString("\"$FOO\" .bar*"));
90 EXPECT_EQ("\"hhof.com/cup?a=b&c=d%20e\"",
91 QueryToString("\"hhof.com/cup?a=b&c=d%20e\""));
92
93 // Leading punctuation should always be stripped.
94 EXPECT_EQ("test*", QueryToString(".test"));
95 EXPECT_EQ("test.*", QueryToString("~test."));
96 EXPECT_EQ("test*", QueryToString("--test"));
97 } 72 }
98 73
99 TEST_F(QueryParserTest, NumWords) { 74 TEST_F(QueryParserTest, NumWords) {
100 TestData data[] = { 75 TestData data[] = {
101 { "blah", 1 }, 76 { "blah", 1 },
102 { "foo \"bar baz\"", 3 }, 77 { "foo \"bar baz\"", 3 },
103 { "foo \"baz\"", 2 }, 78 { "foo \"baz\"", 2 },
104 { "foo \"bar baz\" blah", 4 }, 79 { "foo \"bar baz\" blah", 4 },
105 }; 80 };
106 81
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 QueryParser parser; 154 QueryParser parser;
180 parser.ParseQueryWords(UTF8ToUTF16(data[i].text), &results); 155 parser.ParseQueryWords(UTF8ToUTF16(data[i].text), &results);
181 ASSERT_EQ(data[i].word_count, results.size()); 156 ASSERT_EQ(data[i].word_count, results.size());
182 EXPECT_EQ(data[i].w1, UTF16ToUTF8(results[0])); 157 EXPECT_EQ(data[i].w1, UTF16ToUTF8(results[0]));
183 if (results.size() == 2) 158 if (results.size() == 2)
184 EXPECT_EQ(data[i].w2, UTF16ToUTF8(results[1])); 159 EXPECT_EQ(data[i].w2, UTF16ToUTF8(results[1]));
185 if (results.size() == 3) 160 if (results.size() == 3)
186 EXPECT_EQ(data[i].w3, UTF16ToUTF8(results[2])); 161 EXPECT_EQ(data[i].w3, UTF16ToUTF8(results[2]));
187 } 162 }
188 } 163 }
OLDNEW
« no previous file with comments | « chrome/browser/history/query_parser.cc ('k') | chrome/browser/history/text_database_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698