chrome/browser/extensions/api/declarative/initializing_rules_registry.h - Issue 9380051: Coverity: Fix a few pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry.h

Issue 9380051: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autofill_external_delegate.cc ('k') | chrome/browser/extensions/api/declarative/initializing_rules_registry.cc » ('j') | chrome/renderer/print_web_view_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/initializing_rules_registry.h

diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry.h b/chrome/browser/extensions/api/declarative/initializing_rules_registry.h

index b91c266f2ffaa51d67b0bbfa9773caea273031a5..8aa94a7fb915ab7418a8c60d1fd18e0ed80227ec 100644

--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry.h

+++ b/chrome/browser/extensions/api/declarative/initializing_rules_registry.h

@@ -48,7 +48,7 @@ class InitializingRulesRegistry : public RulesRegistry {

const std::string& rule_id) const;

// Creates an ID that is unique within the scope of|extension_id|.

- std::string GenerateUniqueId(std::string extension_id);

+ std::string GenerateUniqueId(const std::string& extension_id);

// Verifies that all |rules| have unique IDs or initializes them with

// unique IDs if they don't have one. In case of duplicate IDs, this function