chrome/browser/extensions/api/declarative/initializing_rules_registry.cc - Issue 9380051: Coverity: Fix a few pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

Issue 9380051: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/initializing_rules_registry.h ('k') | chrome/renderer/print_web_view_helper.cc » ('j') | chrome/renderer/print_web_view_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

index 91c0e4dd57cc6f49658be31fd51024f26a8bf86b..0a02092c7fe8c3ea78361d6cbea4796afb2a2bdd 100644

--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

@@ -85,7 +85,7 @@ bool InitializingRulesRegistry::IsUniqueId(

}

std::string InitializingRulesRegistry::GenerateUniqueId(

- std::string extension_id) {

+ const std::string& extension_id) {

while (!IsUniqueId(extension_id, ToId(last_generated_rule_identifier_id_)))

++last_generated_rule_identifier_id_;

std::string new_id = ToId(last_generated_rule_identifier_id_);