Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 9380051: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index 491ffee76157b18ddf2f831d6fc4ea5671cd04a1..891b10cc2cfdee8092fe6a2d0faa14081cc22d42 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -138,9 +138,8 @@ void AutofillExternalDelegate::DidEndTextFieldEditing() {
has_shown_autofill_popup_for_current_edit_ = false;
}
-void AutofillExternalDelegate::DidAcceptAutofillSuggestions(string16 value,
- int unique_id,
- unsigned index) {
+void AutofillExternalDelegate::DidAcceptAutofillSuggestions(
+ const string16& value, int unique_id, unsigned index) {
// If the selected element is a warning we don't want to do anything.
if (unique_id < 0)
return;

Powered by Google App Engine
This is Rietveld 408576698