Issue 9380051: Coverity: Fix a few pass-by-values.

Issue 9380051: Coverity: Fix a few pass-by-values. (Closed)

Created:
8 years, 10 months ago by James Hawkins

Modified:
8 years, 9 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, dyu1, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fix a pass-by-value. CID_COUNT=1 CID=103292 BUG=none TEST=none R=groby Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125070

Patch Set 2 : Revert printing. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	base/move.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative/initializing_rules_registry.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/declarative/initializing_rules_registry.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

https://chromiumcodereview.appspot.com/9380051/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): https://chromiumcodereview.appspot.com/9380051/diff/1/chrome/renderer/print_web_view_helper.cc#newcode486 chrome/renderer/print_web_view_helper.cc:486: printing::kSettingHeaderFooterFontSize / webkit_scale_factor)); Are you sure setTextSize can be ...

8 years, 10 months ago (2012-02-13 01:19:33 UTC) #2

James Hawkins

On 2012/02/13 01:19:33, groby wrote: > https://chromiumcodereview.appspot.com/9380051/diff/1/chrome/renderer/print_web_view_helper.cc > File chrome/renderer/print_web_view_helper.cc (right): > > https://chromiumcodereview.appspot.com/9380051/diff/1/chrome/renderer/print_web_view_helper.cc#newcode486 > ...

8 years, 9 months ago (2012-03-04 02:01:24 UTC) #3

lgtm

Expand Messages | Collapse Messages