Coverity: Fix a few pass-by-values.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 365 matching lines @@
   SkPoint point = SkPoint::Make(x / webkit_scale_factor,
                                 y / webkit_scale_factor);
   return point;
 }
 
 // Given a text, the positions, and the paint object, this method gets the
 // coordinates and prints the text at those coordinates on the canvas.
 void PrintHeaderFooterText(
     const string16& text,
     WebKit::WebCanvas* canvas,
-    HeaderFooterPaint paint,
+    const HeaderFooterPaint& paint,
     float webkit_scale_factor,
     const PageSizeMargins& page_layout,
     printing::HorizontalHeaderFooterPosition horizontal_position,
     printing::VerticalHeaderFooterPosition vertical_position,
     double offset_to_baseline) {
 #if defined(USE_SKIA)
   size_t text_byte_length = text.length() * sizeof(char16);
   double text_width_in_points = SkScalarToDouble(paint.measureText(
       text.c_str(), text_byte_length));
   SkPoint point = GetHeaderFooterPosition(webkit_scale_factor, page_layout,
                                           horizontal_position,
                                           vertical_position, offset_to_baseline,
                                           text_width_in_points);
-  paint.setTextSize(SkDoubleToScalar(
-      paint.getTextSize() / webkit_scale_factor));
-  canvas->drawText(text.c_str(), text_byte_length, point.x(), point.y(),
-                   paint);
+  canvas->drawText(text.c_str(), text_byte_length, point.x(), point.y(), paint);
 #elif defined(OS_MACOSX)
   ScopedCFTypeRef<CFStringRef> cf_text(base::SysUTF16ToCFStringRef(text));
   ScopedCFTypeRef<CFAttributedStringRef> cf_attr_text(
       CFAttributedStringCreate(NULL, cf_text, paint));
   ScopedCFTypeRef<CTLineRef> line(CTLineCreateWithAttributedString(
       cf_attr_text));
   double text_width_in_points =
       CTLineGetTypographicBounds(line, NULL, NULL, NULL) * webkit_scale_factor;
   SkPoint point = GetHeaderFooterPosition(webkit_scale_factor,
                                           page_layout, horizontal_position,
@@ skipping 64 matching lines @@
     const PageSizeMargins& page_layout,
     const DictionaryValue& header_footer_info) {
 #if defined(USE_SKIA)
   skia::VectorPlatformDeviceSkia* device =
       static_cast<skia::VectorPlatformDeviceSkia*>(canvas->getTopDevice());
   device->setDrawingArea(SkPDFDevice::kMargin_DrawingArea);
 
   SkPaint paint;
   paint.setColor(SK_ColorBLACK);
   paint.setTextEncoding(SkPaint::kUTF16_TextEncoding);
-  paint.setTextSize(SkDoubleToScalar(printing::kSettingHeaderFooterFontSize));
+  paint.setTextSize(SkDoubleToScalar(
+      printing::kSettingHeaderFooterFontSize / webkit_scale_factor));

[groby-ooo-7-16, 2012/02/13 01:19:34]

Are you sure setTextSize can be hoisted up to here? It's re-used later down...

   paint.setTypeface(SkTypeface::CreateFromName(
       printing::kSettingHeaderFooterFontFamilyName, SkTypeface::kNormal));
 #elif defined(OS_MACOSX)
   gfx::ScopedCGContextSaveGState CGContextSaveGState(canvas);
   CGContextSetCharacterSpacing(canvas,
                                printing::kSettingHeaderFooterCharacterSpacing);
   CGContextSetTextDrawingMode(canvas, kCGTextFill);
   CGContextSetGrayFillColor(canvas, kBlackGrayLevel, kOpaqueLevel);
   CGContextSelectFont(canvas, printing::kSettingHeaderFooterFontName,
                       printing::kSettingHeaderFooterFontSize,
@@ skipping 20 matching lines @@
                                     &title) ||
       !header_footer_info.GetString(printing::kSettingHeaderFooterDate,
                                     &date)) {
     NOTREACHED();
   }
   string16 header_text = date + title;
 
   // Used for height calculations. Note that the width may be undefined.
   SkRect header_vertical_bounds;
 #if defined(USE_SKIA)
   paint.measureText(header_text.c_str(), header_text.length() * sizeof(char16),

[groby-ooo-7-16, 2012/02/13 01:19:34]

Right here. And I'd assume measureText depends on setTextSize()

                     &header_vertical_bounds, 0);
 #elif defined(OS_MACOSX)
   header_vertical_bounds.fTop = CTFontGetAscent(ct_font) * webkit_scale_factor;
   header_vertical_bounds.fBottom = -CTFontGetDescent(ct_font) *
                                    webkit_scale_factor;
 #endif
   double text_height = printing::kSettingHeaderFooterInterstice +
                        header_vertical_bounds.height();
   if (text_height <= page_layout.margin_top) {
     PrintHeaderFooterText(date, canvas, paint, webkit_scale_factor, page_layout,
@@ skipping 1234 matching lines @@
   DCHECK(IsRendering());
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }