Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 9380040: Revert 121620 - Refactor FileSystemOperation to take callback for each method. (Closed)

Created:
8 years, 10 months ago by kinaba
Modified:
8 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, kinuko+watch
Visibility:
Public.

Description

Revert 121620 - Refactor FileSystemOperation to take callback for each method. This patch is the first step for supporting cross-filesystem copy/move on the Filesystem API implementation. To accomplish it, I'm planning to crack FileSystemOperation::{Move,Copy} to a series of other FSO operations. For it, per-method callback is more handy. BUG=110121 TEST=*File* Review URL: http://codereview.chromium.org/9372044 TBR=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1024 lines, -978 lines) Patch
MM chrome/browser/extensions/extension_file_browser_private_api.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/extensions/extension_file_browser_private_api.cc View 7 chunks +60 lines, -31 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.h View 2 chunks +0 lines, -26 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.cc View 10 chunks +100 lines, -134 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_context.h View 4 chunks +5 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 5 chunks +15 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 5 chunks +58 lines, -15 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_operation.h View 8 chunks +69 lines, -100 lines 0 comments Download
M webkit/fileapi/file_system_operation.cc View 27 chunks +166 lines, -182 lines 0 comments Download
M webkit/fileapi/file_system_operation_interface.h View 7 chunks +28 lines, -71 lines 0 comments Download
M webkit/fileapi/file_system_operation_unittest.cc View 51 chunks +108 lines, -139 lines 0 comments Download
M webkit/fileapi/file_system_operation_write_unittest.cc View 13 chunks +55 lines, -30 lines 0 comments Download
M webkit/fileapi/file_system_quota_unittest.cc View 11 chunks +59 lines, -36 lines 0 comments Download
M webkit/fileapi/file_system_test_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_test_helper.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 3 chunks +57 lines, -10 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 5 chunks +49 lines, -17 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 3 chunks +2 lines, -27 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 5 chunks +104 lines, -103 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 5 chunks +65 lines, -33 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinaba
8 years, 10 months ago (2012-02-11 02:44:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698