[depot_tools] Use git fetch to optimize the properly configured that use git-svn

[depot_tools] Use git fetch to optimize the properly configured that use git-svn
in the way <http://code.google.com/p/chromium/wiki/UsingNewGit#Initial_checkout>;
describes.

R=maruel@chromium.org
TEST=gclient sync with safesync_url is faster.
BUG=109184
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121988

[Dan Beam, 2012-02-10 11:07:55]

Hey Marc-Antoine, you mentioned you were a bit busy yesterday so feel free to
nominate a replacement reviewer if you don't have bandwidth (you are still the
majority author the files I touched, I believe, :D).

[M-A Ruel, 2012-02-10 15:53:02]

Chase or Nicolas can also review but they are less intimate.

https://chromiumcodereview.appspot.com/9379005/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/1/gclient_scm.py#newcode504
gclient_scm.py:504: cwd=self.checkout_path).startswith('trunk/src:'):
remove the ".startswith('trunk/src:')" and just look if it's not empty, e.g.:

if scm.GIT.Capture(['config', '--get', 'svn-remote.svn.fetch'],
cwd=self.checkout_path):

[Dan Beam, 2012-02-10 21:59:48]

https://chromiumcodereview.appspot.com/9379005/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/1/gclient_scm.py#newcode504
gclient_scm.py:504: cwd=self.checkout_path).startswith('trunk/src:'):
On 2012/02/10 15:53:02, Marc-Antoine Ruel wrote:
> remove the ".startswith('trunk/src:')" and just look if it's not empty, e.g.:
> 
> if scm.GIT.Capture(['config', '--get', 'svn-remote.svn.fetch'],
> cwd=self.checkout_path):

Done.

[Dan Beam, 2012-02-11 02:21:15]

ping when you have time

[M-A Ruel, 2012-02-11 02:38:08]

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
presubmit_canned_checks.py:859: r'.*? found in the LICENSE file\.(?: \*/)?\n'
Humm I'd rather have that in a separate CL.

https://chromiumcodereview.appspot.com/9379005/diff/3005/tests/trychange_unit...
File tests/trychange_unittest.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/tests/trychange_unit...
tests/trychange_unittest.py:18: # pylint: disable=E1103
?

[Dan Beam, 2012-02-11 02:42:36]

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
presubmit_canned_checks.py:859: r'.*? found in the LICENSE file\.(?: \*/)?\n'
On 2012/02/11 02:38:08, Marc-Antoine Ruel wrote:
> Humm I'd rather have that in a separate CL.

I've never done it because it'd be a 2 char CL, and probably won't if I don't
now, just sayin'.

https://chromiumcodereview.appspot.com/9379005/diff/3005/tests/trychange_unit...
File tests/trychange_unittest.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/tests/trychange_unit...
tests/trychange_unittest.py:18: # pylint: disable=E1103
On 2012/02/11 02:38:08, Marc-Antoine Ruel wrote:
> ?

pylint was complaining that it's type checking sucks when it comes to
.AndReturn() so I fixed it.

[Dan Beam, 2012-02-11 02:45:53]

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
presubmit_canned_checks.py:357: if not license_re.search(contents):
It doesn't check for this group at all.

[M-A Ruel, 2012-02-11 02:51:19]

lgtm

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
presubmit_canned_checks.py:357: if not license_re.search(contents):
On 2012/02/11 02:45:53, Dan Beam wrote:
> It doesn't check for this group at all.

It?

[Dan Beam, 2012-02-11 03:28:10]

https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py
File gclient_scm.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py#newco...
gclient_scm.py:503: if scm.GIT.Capture(['config', '--get',
'svn-remote.svn.fetch'],
actually, should I be wrapping this in a try: except: frame?

[Dan Beam, 2012-02-11 03:28:26]

On 2012/02/11 02:51:19, Marc-Antoine Ruel wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
> File presubmit_canned_checks.py (right):
> 
>
https://chromiumcodereview.appspot.com/9379005/diff/3005/presubmit_canned_che...
> presubmit_canned_checks.py:357: if not license_re.search(contents):
> On 2012/02/11 02:45:53, Dan Beam wrote:
> > It doesn't check for this group at all.
> 
> It?

CheckLicense() doesn't do anything with the match it stores.

[M-A Ruel, 2012-02-14 22:06:19]

https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py
File gclient_scm.py (right):

https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py#newco...
gclient_scm.py:503: if scm.GIT.Capture(['config', '--get',
'svn-remote.svn.fetch'],
On 2012/02/11 03:28:10, Dan Beam wrote:
> actually, should I be wrapping this in a try: except: frame?

Yes

[Dan Beam, 2012-02-14 23:43:03]

On 2012/02/14 22:06:19, Marc-Antoine Ruel wrote:
> https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py
> File gclient_scm.py (right):
> 
>
https://chromiumcodereview.appspot.com/9379005/diff/3005/gclient_scm.py#newco...
> gclient_scm.py:503: if scm.GIT.Capture(['config', '--get',
> 'svn-remote.svn.fetch'],
> On 2012/02/11 03:28:10, Dan Beam wrote:
> > actually, should I be wrapping this in a try: except: frame?
> 
> Yes

Done.

[M-A Ruel, 2012-02-14 23:49:18]

Can you just keep gclient_scm.py and tests/gclient_scm_test.py in this cl? The
other files are unrelated changes.

[Dan Beam, 2012-02-15 01:15:42]

On 2012/02/14 23:49:18, Marc-Antoine Ruel wrote:
> Can you just keep gclient_scm.py and tests/gclient_scm_test.py in this cl? The
> other files are unrelated changes.

Fine, but you have 1-2 more CLs to review, :)? Deal?

[M-A Ruel, 2012-02-15 01:22:18]

On 2012/02/15 01:15:42, Dan Beam wrote:
> On 2012/02/14 23:49:18, Marc-Antoine Ruel wrote:
> > Can you just keep gclient_scm.py and tests/gclient_scm_test.py in this cl?
The
> > other files are unrelated changes.
> 
> Fine, but you have 1-2 more CLs to review, :)? Deal?

deal.

[M-A Ruel, 2012-02-15 01:22:29]

lgtm with only 2 files in this CL

[Dan Beam, 2012-02-15 01:25:40]

On 2012/02/15 01:22:29, Marc-Antoine Ruel wrote:
> lgtm with only 2 files in this CL

Done.

[commit-bot: I haz the power, 2012-02-15 01:26:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9379005/15001

[commit-bot: I haz the power, 2012-02-15 01:32:59]

Change committed as 121988