[depot_tools] Use git fetch to optimize the properly configured that use git-svn

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 336 matching lines @@
 def CheckLicense(input_api, output_api, license_re, source_file_filter=None,
     accept_empty_files=True):
   """Verifies the license header.
   """
   license_re = input_api.re.compile(license_re, input_api.re.MULTILINE)
   bad_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     if accept_empty_files and not contents:
       continue
     if not license_re.search(contents):

[Dan Beam, 2012/02/11 02:45:53]

It doesn't check for this group at all.

[M-A Ruel, 2012/02/11 02:51:19]

It?

       bad_files.append(f.LocalPath())
   if bad_files:
     if input_api.is_committing:
       res_type = output_api.PresubmitPromptWarning
     else:
       res_type = output_api.PresubmitNotifyResult
     return [res_type(
         'License must match:\n%s\n' % license_re.pattern +
         'Found a bad license header in these files:', items=bad_files)]
   return []
@@ skipping 481 matching lines @@
   text_files = tuple(text_files or (
       r'.+\.txt$',
       r'.+\.json$',
   ))
   project_name = project_name or 'Chromium'
   license_header = license_header or (
       r'.*? Copyright \(c\) %(year)s The %(project)s Authors\. '
         r'All rights reserved\.\n'
       r'.*? Use of this source code is governed by a BSD-style license that '
         r'can be\n'
-      r'.*? found in the LICENSE file\.( \*/)?\n'
+      r'.*? found in the LICENSE file\.(?: \*/)?\n'

[M-A Ruel, 2012/02/11 02:38:08]

Humm I'd rather have that in a separate CL.

[Dan Beam, 2012/02/11 02:42:36]

I've never done it because it'd be a 2 char CL, and probably won't if I don't
now, just sayin'.

   ) % {
       'year': input_api.time.strftime('%Y'),
       'project': project_name,
   }
 
   results = []
   # This code loads the default black list (e.g. third_party, experimental, etc)
   # and add our black list (breakpad, skia and v8 are still not following
   # google style and are not really living this repository).
   # See presubmit_support.py InputApi.FilterSourceFile for the (simple) usage.
@@ skipping 44 matching lines @@
     results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
         input_api, output_api))
     snapshot("checking license")
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
     snapshot("checking was uploaded")
     results.extend(input_api.canned_checks.CheckChangeWasUploaded(
         input_api, output_api))
   snapshot("done")
   return results