src/x64/lithium-gap-resolver-x64.cc - Issue 9378006: Make sure that top bits are zero when storing untagged 32 bit values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-gap-resolver-x64.cc

Issue 9378006: Make sure that top bits are zero when storing untagged 32 bit values (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-gap-resolver-x64.cc

===================================================================

--- src/x64/lithium-gap-resolver-x64.cc (revision 10650)

+++ src/x64/lithium-gap-resolver-x64.cc (working copy)

@@ -204,8 +204,9 @@

ASSERT(destination->IsStackSlot());

Operand dst = cgen_->ToOperand(destination);

if (cgen_->IsInteger32Constant(constant_source)) {

- // Allow top 32 bits of an untagged Integer32 to be arbitrary.

- __ movl(dst, Immediate(cgen_->ToInteger32(constant_source)));

+ // Zero top 32 bits of a 64 bit spill slot that holds a 32 bit untagged

+ // value.

+ __ movq(dst, Immediate(cgen_->ToInteger32(constant_source)));

} else {

__ LoadObject(kScratchRegister, cgen_->ToHandle(constant_source));

__ movq(dst, kScratchRegister);

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »