Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/x64/lithium-gap-resolver-x64.cc

Issue 9378006: Make sure that top bits are zero when storing untagged 32 bit values (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 Register dst = cgen_->ToRegister(destination); 197 Register dst = cgen_->ToRegister(destination);
198 if (cgen_->IsInteger32Constant(constant_source)) { 198 if (cgen_->IsInteger32Constant(constant_source)) {
199 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source))); 199 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source)));
200 } else { 200 } else {
201 __ LoadObject(dst, cgen_->ToHandle(constant_source)); 201 __ LoadObject(dst, cgen_->ToHandle(constant_source));
202 } 202 }
203 } else { 203 } else {
204 ASSERT(destination->IsStackSlot()); 204 ASSERT(destination->IsStackSlot());
205 Operand dst = cgen_->ToOperand(destination); 205 Operand dst = cgen_->ToOperand(destination);
206 if (cgen_->IsInteger32Constant(constant_source)) { 206 if (cgen_->IsInteger32Constant(constant_source)) {
207 // Allow top 32 bits of an untagged Integer32 to be arbitrary. 207 // Zero top 32 bits of a 64 bit spill slot that holds a 32 bit untagged
208 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source))); 208 // value.
209 __ movq(dst, Immediate(cgen_->ToInteger32(constant_source)));
209 } else { 210 } else {
210 __ LoadObject(kScratchRegister, cgen_->ToHandle(constant_source)); 211 __ LoadObject(kScratchRegister, cgen_->ToHandle(constant_source));
211 __ movq(dst, kScratchRegister); 212 __ movq(dst, kScratchRegister);
212 } 213 }
213 } 214 }
214 215
215 } else if (source->IsDoubleRegister()) { 216 } else if (source->IsDoubleRegister()) {
216 XMMRegister src = cgen_->ToDoubleRegister(source); 217 XMMRegister src = cgen_->ToDoubleRegister(source);
217 if (destination->IsDoubleRegister()) { 218 if (destination->IsDoubleRegister()) {
218 __ movaps(cgen_->ToDoubleRegister(destination), src); 219 __ movaps(cgen_->ToDoubleRegister(destination), src);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 moves_[i].set_source(source); 313 moves_[i].set_source(source);
313 } 314 }
314 } 315 }
315 } 316 }
316 317
317 #undef __ 318 #undef __
318 319
319 } } // namespace v8::internal 320 } } // namespace v8::internal
320 321
321 #endif // V8_TARGET_ARCH_X64 322 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698