Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 9378006: Make sure that top bits are zero when storing untagged 32 bit values (Closed)

Created:
8 years, 10 months ago by Erik Corry
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make sure that top bits are zero when storing untagged 32 bit values in 64 bit spill slots. Committed: https://code.google.com/p/v8/source/detail?r=10774

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M src/x64/assembler-x64.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 1 chunk +15 lines, -7 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
8 years, 10 months ago (2012-02-10 15:12:09 UTC) #1
ulan
Drive by comment. I think processor already clears out the top bits for 32-bit MOVs. ...
8 years, 10 months ago (2012-02-10 16:45:57 UTC) #2
Erik Corry
Thanks for pointing that out. New version uploaded.
8 years, 10 months ago (2012-02-13 20:18:27 UTC) #3
Vyacheslav Egorov (Chromium)
8 years, 10 months ago (2012-02-15 20:35:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698