Support sharing of ContentMain and BrowserMain code with embedded use cases (try #3).

Support sharing of ContentMain and BrowserMain code with embedded use cases (try #3).

For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately.

To support sharing of this code the following changes were required:

1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions.

2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions.

3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code.

BUG=112507
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121454

[jam, 2012-02-09 17:33:41]

what changed since last commit?

can you upload a patchset with the reverted change, and then upload another one
with the fixes?

[Marshall, 2012-02-09 17:36:12]

On 2012/02/09 17:33:41, John Abd-El-Malek wrote:
> what changed since last commit?
> 
> can you upload a patchset with the reverted change, and then upload another
one
> with the fixes?

Sorry, got ahead of myself (didn't realize that assigning a reviewer sent an
email). This is the original patch set, I haven't changed it yet.

[jam, 2012-02-09 18:21:09]

On 2012/02/09 17:36:12, Marshall wrote:
> On 2012/02/09 17:33:41, John Abd-El-Malek wrote:
> > what changed since last commit?
> > 
> > can you upload a patchset with the reverted change, and then upload another
> one
> > with the fixes?
> 
> Sorry, got ahead of myself (didn't realize that assigning a reviewer sent an
> email). This is the original patch set, I haven't changed it yet.

my bad :) I was just looking at my list of reviews and didn't notice that this
wasn't published yet!

[Marshall, 2012-02-09 21:25:23]

Previous patch set: http://codereview.chromium.org/9347022/

Please review the changes to content_main_runner.cc in delta 4.

With the previous patch set some RendererAccessibilityBrowserTest.* tests were
failing when using a windows component build due to
BrowserAccessibility::Create() failing to initialize a CComObject. The
underlying problem was the allocation of CAppModule on the heap instead of using
a static global.

Unfortunately the only windows component build try bot (win) is non-functional
but these tests are now passing on my local component build.

[jam, 2012-02-09 22:11:30]

lgtm